From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23584 invoked by alias); 15 Mar 2010 09:36:11 -0000 Received: (qmail 23568 invoked by uid 22791); 15 Mar 2010 09:36:10 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Mar 2010 09:36:05 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2F9ZgiO023804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 15 Mar 2010 05:35:43 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2F9ZeWd000749 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 15 Mar 2010 05:35:42 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o2F9Zdvo031896; Mon, 15 Mar 2010 10:35:39 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o2F9ZdE7031895; Mon, 15 Mar 2010 10:35:39 +0100 Date: Mon, 15 Mar 2010 09:36:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix false warning: section .dynbss not found in ... Message-ID: <20100315093538.GA31219@host0.dyn.jankratochvil.net> References: <20100314213746.GA32276@host0.dyn.jankratochvil.net> <20100315004502.GE3045@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100315004502.GE3045@adacore.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00535.txt.bz2 On Mon, 15 Mar 2010 01:45:02 +0100, Joel Brobecker wrote: > The comment should say "a few sections" as opposed to "a couple" (a > couple is two, or three at most), http://en.wiktionary.org/wiki/couple#Usage_notes * In the U.S., "a couple of things" or people may be used to mean two of them, but it is also often used to mean any small number. The farm is a couple of miles off the main highway [=a few miles away]. But I understand I can't argue about U.S. English. :-) > and it should say that there is no > other way to identify these section except by name. > > Pre-approved with that comment update. I hope it is +/- OK, checked-in. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2010-03/msg00138.html --- src/gdb/ChangeLog 2010/03/15 03:48:46 1.11479 +++ src/gdb/ChangeLog 2010/03/15 09:31:30 1.11480 @@ -1,3 +1,8 @@ +2010-03-15 Jan Kratochvil + + * symfile.c (addr_info_make_relative): Ignore also missing ".dynbss" + and ".sdynbss". Update the comment. + 2010-03-15 Jie Zhang * MAINTAINERS: Update my email address. --- src/gdb/symfile.c 2010/03/10 18:20:07 1.277 +++ src/gdb/symfile.c 2010/03/15 09:31:34 1.278 @@ -576,16 +576,19 @@ /* This section does not exist in ABFD, which is normally unexpected and we want to issue a warning. - However, the ELF prelinker does create a couple of sections - (".gnu.liblist" and ".gnu.conflict") which are marked in the main - executable as loadable (they are loaded in memory from the - DYNAMIC segment) and yet are not present in separate debug info - files. This is fine, and should not cause a warning. Shared - libraries contain just the section ".gnu.liblist" but it is not - marked as loadable there. */ + However, the ELF prelinker does create a few sections which are + marked in the main executable as loadable (they are loaded in + memory from the DYNAMIC segment) and yet are not present in + separate debug info files. This is fine, and should not cause + a warning. Shared libraries contain just the section + ".gnu.liblist" but it is not marked as loadable there. There is + no other way to identify them than by their name as the sections + created by prelink have no special flags. */ if (!(strcmp (sect_name, ".gnu.liblist") == 0 - || strcmp (sect_name, ".gnu.conflict") == 0)) + || strcmp (sect_name, ".gnu.conflict") == 0 + || strcmp (sect_name, ".dynbss") == 0 + || strcmp (sect_name, ".sdynbss") == 0)) warning (_("section %s not found in %s"), sect_name, bfd_get_filename (abfd));