From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [RFA] Fix remote-fileio.c compilation for Cygwin 1.5 API
Date: Wed, 10 Mar 2010 15:57:00 -0000 [thread overview]
Message-ID: <20100310155729.GA20318@ednor.casa.cgf.cx> (raw)
In-Reply-To: <000901cabfe3$43c6bda0$cb5438e0$@muller@ics-cnrs.unistra.fr>
On Wed, Mar 10, 2010 at 12:50:14AM +0100, Pierre Muller wrote:
>Hi Christopher,
>> >I just discovered for windows-nat.c
>> >
>> >See http://sourceware.org/ml/gdb-patches/2010-03/msg00344.html
>>
>> You're right. My macro was too simple minded. I've checked in your
>> change to windows-nat.c. If you want to use that in remote-fileio.c
>> that's fine. Or not. It really isn't a big deal either way.
>Thanks for the check-in.
>
> OK, here is a new, lighter version of the remote-fileio.c patch...
>There is also a small problem remaining for windows-nat.c
>(the previous definition of the cygwin_conv_path macro
>needs to be removed).
>
>Is this patch OK?
>
>Pierre
>
>2010-03-10 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * remote-fileio.c (cygwin_conv_path): Define macro for old cygwin
>API.
> * windows-nat.c (cygwin_conv_path): Remove old macro.
I've checked in the windows-nat.c change. The remote-fileio.c change looks
good to me.
cgf
next prev parent reply other threads:[~2010-03-10 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 16:13 Pierre Muller
2010-03-08 20:09 ` Daniel Jacobowitz
2010-03-08 21:49 ` Christopher Faylor
2010-03-08 21:55 ` Daniel Jacobowitz
2010-03-08 23:21 ` Pierre Muller
2010-03-09 19:15 ` Christopher Faylor
2010-03-09 23:50 ` Pierre Muller
2010-03-10 15:57 ` Christopher Faylor [this message]
2010-03-10 16:42 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310155729.GA20318@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox