From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6790 invoked by alias); 10 Mar 2010 15:57:38 -0000 Received: (qmail 6782 invoked by uid 22791); 10 Mar 2010 15:57:35 -0000 X-Spam-Check-By: sourceware.org Received: from pool-96-252-118-25.bstnma.fios.verizon.net (HELO cgf.cx) (96.252.118.25) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Wed, 10 Mar 2010 15:57:31 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id C6C8C3B0002; Wed, 10 Mar 2010 10:57:29 -0500 (EST) Received: by ednor.cgf.cx (Postfix, from userid 201) id C262F2B352; Wed, 10 Mar 2010 10:57:29 -0500 (EST) Date: Wed, 10 Mar 2010 15:57:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org, Pierre Muller Subject: Re: [RFA] Fix remote-fileio.c compilation for Cygwin 1.5 API Message-ID: <20100310155729.GA20318@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org, Pierre Muller References: <000901cabeda$3cd7bd00$b6873700$@muller@ics-cnrs.unistra.fr> <20100308200858.GA28304@caradoc.them.org> <20100308214856.GA18247@ednor.casa.cgf.cx> <000f01cabf16$07402330$15c06990$@muller@ics-cnrs.unistra.fr> <20100309191512.GB2977@ednor.casa.cgf.cx> <000901cabfe3$43c6bda0$cb5438e0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000901cabfe3$43c6bda0$cb5438e0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00384.txt.bz2 On Wed, Mar 10, 2010 at 12:50:14AM +0100, Pierre Muller wrote: >Hi Christopher, >> >I just discovered for windows-nat.c >> > >> >See http://sourceware.org/ml/gdb-patches/2010-03/msg00344.html >> >> You're right. My macro was too simple minded. I've checked in your >> change to windows-nat.c. If you want to use that in remote-fileio.c >> that's fine. Or not. It really isn't a big deal either way. >Thanks for the check-in. > > OK, here is a new, lighter version of the remote-fileio.c patch... >There is also a small problem remaining for windows-nat.c >(the previous definition of the cygwin_conv_path macro >needs to be removed). > >Is this patch OK? > >Pierre > >2010-03-10 Pierre Muller > > * remote-fileio.c (cygwin_conv_path): Define macro for old cygwin >API. > * windows-nat.c (cygwin_conv_path): Remove old macro. I've checked in the windows-nat.c change. The remote-fileio.c change looks good to me. cgf