From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Subject: RE: [RFA] Fix remote-fileio.c compilation for Cygwin 1.5 API
Date: Mon, 08 Mar 2010 23:21:00 -0000 [thread overview]
Message-ID: <000f01cabf16$07402330$15c06990$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20100308214856.GA18247@ednor.casa.cgf.cx>
> >> I do not really know if there is a specific maintainer for this
> >> file... Could someone (a global maintainr?)
> >> please review this patch?
> >
> >This is OK.
>
> Sorry, I guess I was wrong about the opinion. I do have a mild one.
>
> While I said I didn't have an opinion about this, wouldn't it really
> make sense to use the same mechanism that I adopted for windows-nat.c?
The problem is that this macro does not check the value of the first
argument, which makes me fear that if someone reuses
cygwin_conv_path function elsewhere inside remote-fileio.c source
we might get into the same troubles as the ones
I just discovered for windows-nat.c
See http://sourceware.org/ml/gdb-patches/2010-03/msg00344.html
Pierre
next prev parent reply other threads:[~2010-03-08 23:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 16:13 Pierre Muller
2010-03-08 20:09 ` Daniel Jacobowitz
2010-03-08 21:49 ` Christopher Faylor
2010-03-08 21:55 ` Daniel Jacobowitz
2010-03-08 23:21 ` Pierre Muller [this message]
2010-03-09 19:15 ` Christopher Faylor
2010-03-09 23:50 ` Pierre Muller
2010-03-10 15:57 ` Christopher Faylor
2010-03-10 16:42 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000f01cabf16$07402330$15c06990$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox