From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5749 invoked by alias); 8 Mar 2010 23:21:06 -0000 Received: (qmail 5739 invoked by uid 22791); 8 Mar 2010 23:21:05 -0000 X-SWARE-Spam-Status: No, hits=-0.5 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Mar 2010 23:21:02 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id o28NKwXc027923 for ; Tue, 9 Mar 2010 00:20:58 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o28NKwJE043426 for ; Tue, 9 Mar 2010 00:20:58 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o28NKwQb086223 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Tue, 9 Mar 2010 00:20:58 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: References: <000901cabeda$3cd7bd00$b6873700$@muller@ics-cnrs.unistra.fr> <20100308200858.GA28304@caradoc.them.org> <20100308214856.GA18247@ednor.casa.cgf.cx> In-Reply-To: <20100308214856.GA18247@ednor.casa.cgf.cx> Subject: RE: [RFA] Fix remote-fileio.c compilation for Cygwin 1.5 API Date: Mon, 08 Mar 2010 23:21:00 -0000 Message-ID: <000f01cabf16$07402330$15c06990$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00345.txt.bz2 > >> I do not really know if there is a specific maintainer for this > >> file... Could someone (a global maintainr?) > >> please review this patch? > > > >This is OK. > > Sorry, I guess I was wrong about the opinion. I do have a mild one. > > While I said I didn't have an opinion about this, wouldn't it really > make sense to use the same mechanism that I adopted for windows-nat.c? The problem is that this macro does not check the value of the first argument, which makes me fear that if someone reuses cygwin_conv_path function elsewhere inside remote-fileio.c source we might get into the same troubles as the ones I just discovered for windows-nat.c See http://sourceware.org/ml/gdb-patches/2010-03/msg00344.html Pierre