Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: gdb-patches@sourceware.org, 	"Pinski,
	Andrew" <Andrew.Pinski@caviumnetworks.com>
Subject: Re: [PATCH] Make mips-linux signal frame unwinding more robust.
Date: Thu, 25 Feb 2010 17:47:00 -0000	[thread overview]
Message-ID: <20100225174739.GA2851@adacore.com> (raw)
In-Reply-To: <4B82CEC4.2010607@caviumnetworks.com>

> This patch makes gdb follow suit and find the sigcontext_base using
> the signal frame's SP rather than an offset from the trampoline.

Is there a document that explains that the sigcontext structure is
always going to be at the frame's SP?

I don't know mips-linux, but something looked funny to me: You avoid
the use of SIGFRAME_CODE_OFFSET to compute the address where the sigcontext
structure is located, but you still use it to compute the frame base
address (used when building the frame ID).  Is the frame base address
still a constant offset from FUNC, or does the frame ID base address
also needs to be changed.

I believe that Daniel J has a good knowledge of mips-linux, and would be
an ideal reviewer.  If he doesn't have time, though, I'm OK with approving
a patch for the HEAD branch.  For the 7.1 branch, though, I'd rather have
a more knowledgeable opinion.

-- 
Joel


  reply	other threads:[~2010-02-25 17:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22 18:36 David Daney
2010-02-25 17:47 ` Joel Brobecker [this message]
2010-02-25 18:49   ` David Daney
2010-02-26 18:23     ` David Daney
2010-02-26 20:50       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100225174739.GA2851@adacore.com \
    --to=brobecker@adacore.com \
    --cc=Andrew.Pinski@caviumnetworks.com \
    --cc=ddaney@caviumnetworks.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox