From: Daniel Jacobowitz <dan@codesourcery.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: gdb-patches@sourceware.org,
Joel Brobecker <brobecker@adacore.com>,
"Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH] Make mips-linux signal frame unwinding more robust.
Date: Fri, 26 Feb 2010 20:50:00 -0000 [thread overview]
Message-ID: <20100226205016.GB2630@caradoc.them.org> (raw)
In-Reply-To: <4B881151.9070300@caviumnetworks.com>
On Fri, Feb 26, 2010 at 10:22:09AM -0800, David Daney wrote:
> The current signal frame unwinding code in mips-linux-tdep.c assumes
> a constant offset from the signal return trampoline to the signal
> frame. The assumption does not hold for all kernels. Specifically
> those that have to be compiled with ICACHE_REFILLS_WORKAROUND_WAR
> set (SGI O2 for example). In the near future, it is likely that the
> assumption will cease to hold universally, as we are attempting to
> move the signal return trampoline off the stack entirely.
It's funny, I thought I'd already taught GDB about the WAR workaround,
but there's no hint of it. Your patch looks good to me.
> OK to commit?
>
> How about on the 7.1 branch?
OK both.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2010-02-26 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 18:36 David Daney
2010-02-25 17:47 ` Joel Brobecker
2010-02-25 18:49 ` David Daney
2010-02-26 18:23 ` David Daney
2010-02-26 20:50 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100226205016.GB2630@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=Andrew.Pinski@caviumnetworks.com \
--cc=brobecker@adacore.com \
--cc=ddaney@caviumnetworks.com \
--cc=gdb-patches@sourceware.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox