From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26864 invoked by alias); 25 Feb 2010 17:47:46 -0000 Received: (qmail 26843 invoked by uid 22791); 25 Feb 2010 17:47:44 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Feb 2010 17:47:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BE3FF2BAB0F; Thu, 25 Feb 2010 12:47:39 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mX41trirJVvz; Thu, 25 Feb 2010 12:47:39 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A37352BAAF3; Thu, 25 Feb 2010 12:47:39 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 19418F5896; Thu, 25 Feb 2010 12:47:39 -0500 (EST) Date: Thu, 25 Feb 2010 17:47:00 -0000 From: Joel Brobecker To: David Daney Cc: gdb-patches@sourceware.org, "Pinski, Andrew" Subject: Re: [PATCH] Make mips-linux signal frame unwinding more robust. Message-ID: <20100225174739.GA2851@adacore.com> References: <4B82CEC4.2010607@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B82CEC4.2010607@caviumnetworks.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00624.txt.bz2 > This patch makes gdb follow suit and find the sigcontext_base using > the signal frame's SP rather than an offset from the trampoline. Is there a document that explains that the sigcontext structure is always going to be at the frame's SP? I don't know mips-linux, but something looked funny to me: You avoid the use of SIGFRAME_CODE_OFFSET to compute the address where the sigcontext structure is located, but you still use it to compute the frame base address (used when building the frame ID). Is the frame base address still a constant offset from FUNC, or does the frame ID base address also needs to be changed. I believe that Daniel J has a good knowledge of mips-linux, and would be an ideal reviewer. If he doesn't have time, though, I'm OK with approving a patch for the HEAD branch. For the 7.1 branch, though, I'd rather have a more knowledgeable opinion. -- Joel