[PATCH]: Enable catch syscall test on sparc

[PATCH]: Enable catch syscall test on sparc

[David Miller]

Now that these sparc targets support this feature we can enable the
test in the testsuite.

While doing this I also noticed that the logic for setting the
all_syscalls_numbers array was wrong, the test always evaluates to
true because it goes:

	if (!ARCH1 || !ARCH2 || ...

instead of the correct:

	if (ARCH1 || ARCH2 || ...

so that gets fixed here too.

Ok to commit?

gdb: Enable catch syscall test on sparc*-*-liunx and fix logic bug.

gdb/testsuite/

2010-02-25  David S. Miller  <davem@davemloft.net>

	* gdb.base/catch-syscall.exp: Allow to run on sparc*-*-linux and
	fix logic for setting all_syscalls_numbers.
---
 gdb/testsuite/gdb.base/catch-syscall.exp |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/gdb/testsuite/gdb.base/catch-syscall.exp b/gdb/testsuite/gdb.base/catch-syscall.exp
index 4d5c3cb..ee385ad 100644
--- a/gdb/testsuite/gdb.base/catch-syscall.exp
+++ b/gdb/testsuite/gdb.base/catch-syscall.exp
@@ -54,7 +54,8 @@ if {![istarget "hppa*-hp-hpux*"] && ![istarget "*-linux*"]} then {
 # on some architecture.
 #if { ![istarget "i\[34567\]86-*-linux*"]
 if { ![istarget "x86_64-*-linux*"] && ![istarget "i\[34567\]86-*-linux*"]
-     && ![istarget "powerpc-*-linux*"] && ![istarget "powerpc64-*-linux*"] } {
+     && ![istarget "powerpc-*-linux*"] && ![istarget "powerpc64-*-linux*"]
+     && ![istarget "sparc-*-linux*"] && ![istarget "sparc64-*-linux*"] } {
      continue
 }
 
@@ -415,10 +416,11 @@ proc do_syscall_tests_without_xml {} {
 proc fill_all_syscalls_numbers {} {
     global all_syscalls_numbers
 
-    # For Linux on x86, PPC and PPC64, the numbers for the syscalls "close" and
-    # "chroot" are the same.
-    if { ![istarget "i\[34567\]86-*-linux*"]
-         || ![istarget "powerpc-*-linux*"] || ![istarget "powerpc64-*-linux*"] } {
+    # For Linux on x86, PPC, PPC64, SPARC and SPARC64, the numbers for the syscalls
+    # "close" and "chroot" are the same.
+    if { [istarget "i\[34567\]86-*-linux*"]
+         || [istarget "powerpc-*-linux*"] || [istarget "powerpc64-*-linux*"]
+         || [istarget "sparc-*-linux*"] || [istarget "sparc64-*-linux*"] } {
          set all_syscalls_numbers { "6" "61" }
     }
 }
-- 
1.6.6.1

Re: [PATCH]: Enable catch syscall test on sparc

[Daniel Jacobowitz]

On Thu, Feb 25, 2010 at 08:03:47AM -0800, David Miller wrote:
> 
> Now that these sparc targets support this feature we can enable the
> test in the testsuite.
> 
> While doing this I also noticed that the logic for setting the
> all_syscalls_numbers array was wrong, the test always evaluates to
> true because it goes:
> 
> 	if (!ARCH1 || !ARCH2 || ...
> 
> instead of the correct:
> 
> 	if (ARCH1 || ARCH2 || ...
> 
> so that gets fixed here too.
> 
> Ok to commit?

OK, thanks.

-- 
Daniel Jacobowitz
CodeSourcery