From: David Miller <davem@davemloft.net>
To: gdb-patches@sourceware.org
Subject: [PATCH]: Enable catch syscall test on sparc
Date: Thu, 25 Feb 2010 16:03:00 -0000 [thread overview]
Message-ID: <20100225.080347.123279217.davem@davemloft.net> (raw)
Now that these sparc targets support this feature we can enable the
test in the testsuite.
While doing this I also noticed that the logic for setting the
all_syscalls_numbers array was wrong, the test always evaluates to
true because it goes:
if (!ARCH1 || !ARCH2 || ...
instead of the correct:
if (ARCH1 || ARCH2 || ...
so that gets fixed here too.
Ok to commit?
gdb: Enable catch syscall test on sparc*-*-liunx and fix logic bug.
gdb/testsuite/
2010-02-25 David S. Miller <davem@davemloft.net>
* gdb.base/catch-syscall.exp: Allow to run on sparc*-*-linux and
fix logic for setting all_syscalls_numbers.
---
gdb/testsuite/gdb.base/catch-syscall.exp | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/gdb.base/catch-syscall.exp b/gdb/testsuite/gdb.base/catch-syscall.exp
index 4d5c3cb..ee385ad 100644
--- a/gdb/testsuite/gdb.base/catch-syscall.exp
+++ b/gdb/testsuite/gdb.base/catch-syscall.exp
@@ -54,7 +54,8 @@ if {![istarget "hppa*-hp-hpux*"] && ![istarget "*-linux*"]} then {
# on some architecture.
#if { ![istarget "i\[34567\]86-*-linux*"]
if { ![istarget "x86_64-*-linux*"] && ![istarget "i\[34567\]86-*-linux*"]
- && ![istarget "powerpc-*-linux*"] && ![istarget "powerpc64-*-linux*"] } {
+ && ![istarget "powerpc-*-linux*"] && ![istarget "powerpc64-*-linux*"]
+ && ![istarget "sparc-*-linux*"] && ![istarget "sparc64-*-linux*"] } {
continue
}
@@ -415,10 +416,11 @@ proc do_syscall_tests_without_xml {} {
proc fill_all_syscalls_numbers {} {
global all_syscalls_numbers
- # For Linux on x86, PPC and PPC64, the numbers for the syscalls "close" and
- # "chroot" are the same.
- if { ![istarget "i\[34567\]86-*-linux*"]
- || ![istarget "powerpc-*-linux*"] || ![istarget "powerpc64-*-linux*"] } {
+ # For Linux on x86, PPC, PPC64, SPARC and SPARC64, the numbers for the syscalls
+ # "close" and "chroot" are the same.
+ if { [istarget "i\[34567\]86-*-linux*"]
+ || [istarget "powerpc-*-linux*"] || [istarget "powerpc64-*-linux*"]
+ || [istarget "sparc-*-linux*"] || [istarget "sparc64-*-linux*"] } {
set all_syscalls_numbers { "6" "61" }
}
}
--
1.6.6.1
next reply other threads:[~2010-02-25 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 16:03 David Miller [this message]
2010-02-25 17:33 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225.080347.123279217.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox