* [commit] Fix gdb.multi test execution
@ 2010-02-19 17:15 Ulrich Weigand
2010-02-19 17:41 ` Pedro Alves
2010-02-19 18:04 ` Joel Brobecker
0 siblings, 2 replies; 4+ messages in thread
From: Ulrich Weigand @ 2010-02-19 17:15 UTC (permalink / raw)
To: gdb-patches; +Cc: brobecker
Hello,
it seems the new gdb.multi test cases were actually never run
(at least in a separate-build-directory configuration), because
the subdirectory wasn't even created in the build directory.
This seems to be caused by the fact that gdb.multi is the only
subdirectory whose Makefile is not listed in AC_OUTPUT in
configure; this looks like an oversight.
The following patch fixes this, which causes the gdb.multi tests
to run (successfully) for me.
Tested on powerpc64-linux; applied to mainline.
Joel, do you think this would be something for the branch?
Bye,
Ulrich
ChangeLog:
testsuite/
* configure.ac: Add gdb.multi/Makefile to AC_OUTPUT.
* configure: Regenerate.
Index: gdb/testsuite/configure
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/configure,v
retrieving revision 1.33
diff -u -p -r1.33 configure
--- gdb/testsuite/configure 22 Aug 2009 16:56:43 -0000 1.33
+++ gdb/testsuite/configure 19 Feb 2010 17:05:13 -0000
@@ -3515,7 +3515,7 @@ done
-ac_config_files="$ac_config_files Makefile gdb.ada/Makefile gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile gdb.fortran/Makefile gdb.server/Makefile gdb.java/Makefile gdb.mi/Makefile gdb.modula2/Makefile gdb.objc/Makefile gdb.opt/Makefile gdb.pascal/Makefile gdb.python/Makefile gdb.reverse/Makefile gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile"
+ac_config_files="$ac_config_files Makefile gdb.ada/Makefile gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile gdb.fortran/Makefile gdb.server/Makefile gdb.java/Makefile gdb.mi/Makefile gdb.modula2/Makefile gdb.multi/Makefile gdb.objc/Makefile gdb.opt/Makefile gdb.pascal/Makefile gdb.python/Makefile gdb.reverse/Makefile gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile"
cat >confcache <<\_ACEOF
# This file is a shell script that caches the results of configure
@@ -4228,6 +4228,7 @@ do
"gdb.java/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.java/Makefile" ;;
"gdb.mi/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.mi/Makefile" ;;
"gdb.modula2/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.modula2/Makefile" ;;
+ "gdb.multi/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.multi/Makefile" ;;
"gdb.objc/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.objc/Makefile" ;;
"gdb.opt/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.opt/Makefile" ;;
"gdb.pascal/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.pascal/Makefile" ;;
Index: gdb/testsuite/configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/configure.ac,v
retrieving revision 1.16
diff -u -p -r1.16 configure.ac
--- gdb/testsuite/configure.ac 1 Jan 2010 09:44:07 -0000 1.16
+++ gdb/testsuite/configure.ac 19 Feb 2010 17:05:13 -0000
@@ -142,8 +142,8 @@ AC_OUTPUT([Makefile \
gdb.ada/Makefile \
gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile \
gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile \
- gdb.fortran/Makefile gdb.server/Makefile \
- gdb.java/Makefile gdb.mi/Makefile gdb.modula2/Makefile \
+ gdb.fortran/Makefile gdb.server/Makefile gdb.java/Makefile \
+ gdb.mi/Makefile gdb.modula2/Makefile gdb.multi/Makefile \
gdb.objc/Makefile gdb.opt/Makefile gdb.pascal/Makefile \
gdb.python/Makefile gdb.reverse/Makefile \
gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile])
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [commit] Fix gdb.multi test execution
2010-02-19 17:15 [commit] Fix gdb.multi test execution Ulrich Weigand
@ 2010-02-19 17:41 ` Pedro Alves
2010-02-19 18:04 ` Joel Brobecker
1 sibling, 0 replies; 4+ messages in thread
From: Pedro Alves @ 2010-02-19 17:41 UTC (permalink / raw)
To: gdb-patches; +Cc: Ulrich Weigand, brobecker
On Friday 19 February 2010 17:15:19, Ulrich Weigand wrote:
> Hello,
>
> it seems the new gdb.multi test cases were actually never run
> (at least in a separate-build-directory configuration), because
> the subdirectory wasn't even created in the build directory.
Bizarre! They have been running for me. I do have
a build/gdb/testsuite/gdb.multi directory, and gdb.multi tests
show up on my gdb.sum. I can only guess that
I inadvertently dropped something like your patch before
committing that new test dir to CVS, and I haven't
rebuilt my main GDB build dir from clean scratch for a long
long time to notice it. :-) I've now deleted my gdb.multi
and reran config.status, and indeed, it wasn't rebuilt. Thanks
for fixing!
>
> This seems to be caused by the fact that gdb.multi is the only
> subdirectory whose Makefile is not listed in AC_OUTPUT in
> configure; this looks like an oversight.
>
> The following patch fixes this, which causes the gdb.multi tests
> to run (successfully) for me.
>
> Tested on powerpc64-linux; applied to mainline.
>
> Joel, do you think this would be something for the branch?
>
>
> Bye,
> Ulrich
>
>
> ChangeLog:
>
> testsuite/
> * configure.ac: Add gdb.multi/Makefile to AC_OUTPUT.
> * configure: Regenerate.
>
> Index: gdb/testsuite/configure
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/configure,v
> retrieving revision 1.33
> diff -u -p -r1.33 configure
> --- gdb/testsuite/configure 22 Aug 2009 16:56:43 -0000 1.33
> +++ gdb/testsuite/configure 19 Feb 2010 17:05:13 -0000
> @@ -3515,7 +3515,7 @@ done
>
>
>
> -ac_config_files="$ac_config_files Makefile gdb.ada/Makefile gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile gdb.fortran/Makefile gdb.server/Makefile gdb.java/Makefile gdb.mi/Makefile gdb.modula2/Makefile gdb.objc/Makefile gdb.opt/Makefile gdb.pascal/Makefile gdb.python/Makefile gdb.reverse/Makefile gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile"
> +ac_config_files="$ac_config_files Makefile gdb.ada/Makefile gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile gdb.fortran/Makefile gdb.server/Makefile gdb.java/Makefile gdb.mi/Makefile gdb.modula2/Makefile gdb.multi/Makefile gdb.objc/Makefile gdb.opt/Makefile gdb.pascal/Makefile gdb.python/Makefile gdb.reverse/Makefile gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile"
>
> cat >confcache <<\_ACEOF
> # This file is a shell script that caches the results of configure
> @@ -4228,6 +4228,7 @@ do
> "gdb.java/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.java/Makefile" ;;
> "gdb.mi/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.mi/Makefile" ;;
> "gdb.modula2/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.modula2/Makefile" ;;
> + "gdb.multi/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.multi/Makefile" ;;
> "gdb.objc/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.objc/Makefile" ;;
> "gdb.opt/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.opt/Makefile" ;;
> "gdb.pascal/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.pascal/Makefile" ;;
> Index: gdb/testsuite/configure.ac
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/configure.ac,v
> retrieving revision 1.16
> diff -u -p -r1.16 configure.ac
> --- gdb/testsuite/configure.ac 1 Jan 2010 09:44:07 -0000 1.16
> +++ gdb/testsuite/configure.ac 19 Feb 2010 17:05:13 -0000
> @@ -142,8 +142,8 @@ AC_OUTPUT([Makefile \
> gdb.ada/Makefile \
> gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile \
> gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile \
> - gdb.fortran/Makefile gdb.server/Makefile \
> - gdb.java/Makefile gdb.mi/Makefile gdb.modula2/Makefile \
> + gdb.fortran/Makefile gdb.server/Makefile gdb.java/Makefile \
> + gdb.mi/Makefile gdb.modula2/Makefile gdb.multi/Makefile \
> gdb.objc/Makefile gdb.opt/Makefile gdb.pascal/Makefile \
> gdb.python/Makefile gdb.reverse/Makefile \
> gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile])
>
--
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [commit] Fix gdb.multi test execution
2010-02-19 17:15 [commit] Fix gdb.multi test execution Ulrich Weigand
2010-02-19 17:41 ` Pedro Alves
@ 2010-02-19 18:04 ` Joel Brobecker
2010-02-19 19:18 ` Ulrich Weigand
1 sibling, 1 reply; 4+ messages in thread
From: Joel Brobecker @ 2010-02-19 18:04 UTC (permalink / raw)
To: Ulrich Weigand; +Cc: gdb-patches
> Joel, do you think this would be something for the branch?
Yep - looks good to me.
Note while looking at this: Ã…AC_OUTPUT(...) is deprecated, apparently.
Now, we're supposed to do:
AC_CONFIG_FILES(...)
AC_CONFIG_COMMANDS(...) <--- I don't think we actually need this part
AC_OUTPUT
Something for a rainy day...
--
Joel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-02-19 19:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-19 17:15 [commit] Fix gdb.multi test execution Ulrich Weigand
2010-02-19 17:41 ` Pedro Alves
2010-02-19 18:04 ` Joel Brobecker
2010-02-19 19:18 ` Ulrich Weigand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox