From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12467 invoked by alias); 19 Feb 2010 17:41:15 -0000 Received: (qmail 12452 invoked by uid 22791); 19 Feb 2010 17:41:14 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Feb 2010 17:41:10 +0000 Received: (qmail 10342 invoked from network); 19 Feb 2010 17:41:08 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 19 Feb 2010 17:41:08 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [commit] Fix gdb.multi test execution Date: Fri, 19 Feb 2010 17:41:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; ) Cc: "Ulrich Weigand" , brobecker@adacore.com References: <201002191715.o1JHFJN9023171@d12av02.megacenter.de.ibm.com> In-Reply-To: <201002191715.o1JHFJN9023171@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201002191741.05578.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00493.txt.bz2 On Friday 19 February 2010 17:15:19, Ulrich Weigand wrote: > Hello, > > it seems the new gdb.multi test cases were actually never run > (at least in a separate-build-directory configuration), because > the subdirectory wasn't even created in the build directory. Bizarre! They have been running for me. I do have a build/gdb/testsuite/gdb.multi directory, and gdb.multi tests show up on my gdb.sum. I can only guess that I inadvertently dropped something like your patch before committing that new test dir to CVS, and I haven't rebuilt my main GDB build dir from clean scratch for a long long time to notice it. :-) I've now deleted my gdb.multi and reran config.status, and indeed, it wasn't rebuilt. Thanks for fixing! > > This seems to be caused by the fact that gdb.multi is the only > subdirectory whose Makefile is not listed in AC_OUTPUT in > configure; this looks like an oversight. > > The following patch fixes this, which causes the gdb.multi tests > to run (successfully) for me. > > Tested on powerpc64-linux; applied to mainline. > > Joel, do you think this would be something for the branch? > > > Bye, > Ulrich > > > ChangeLog: > > testsuite/ > * configure.ac: Add gdb.multi/Makefile to AC_OUTPUT. > * configure: Regenerate. > > Index: gdb/testsuite/configure > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/configure,v > retrieving revision 1.33 > diff -u -p -r1.33 configure > --- gdb/testsuite/configure 22 Aug 2009 16:56:43 -0000 1.33 > +++ gdb/testsuite/configure 19 Feb 2010 17:05:13 -0000 > @@ -3515,7 +3515,7 @@ done > > > > -ac_config_files="$ac_config_files Makefile gdb.ada/Makefile gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile gdb.fortran/Makefile gdb.server/Makefile gdb.java/Makefile gdb.mi/Makefile gdb.modula2/Makefile gdb.objc/Makefile gdb.opt/Makefile gdb.pascal/Makefile gdb.python/Makefile gdb.reverse/Makefile gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile" > +ac_config_files="$ac_config_files Makefile gdb.ada/Makefile gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile gdb.fortran/Makefile gdb.server/Makefile gdb.java/Makefile gdb.mi/Makefile gdb.modula2/Makefile gdb.multi/Makefile gdb.objc/Makefile gdb.opt/Makefile gdb.pascal/Makefile gdb.python/Makefile gdb.reverse/Makefile gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile" > > cat >confcache <<\_ACEOF > # This file is a shell script that caches the results of configure > @@ -4228,6 +4228,7 @@ do > "gdb.java/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.java/Makefile" ;; > "gdb.mi/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.mi/Makefile" ;; > "gdb.modula2/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.modula2/Makefile" ;; > + "gdb.multi/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.multi/Makefile" ;; > "gdb.objc/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.objc/Makefile" ;; > "gdb.opt/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.opt/Makefile" ;; > "gdb.pascal/Makefile") CONFIG_FILES="$CONFIG_FILES gdb.pascal/Makefile" ;; > Index: gdb/testsuite/configure.ac > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/configure.ac,v > retrieving revision 1.16 > diff -u -p -r1.16 configure.ac > --- gdb/testsuite/configure.ac 1 Jan 2010 09:44:07 -0000 1.16 > +++ gdb/testsuite/configure.ac 19 Feb 2010 17:05:13 -0000 > @@ -142,8 +142,8 @@ AC_OUTPUT([Makefile \ > gdb.ada/Makefile \ > gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile \ > gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile \ > - gdb.fortran/Makefile gdb.server/Makefile \ > - gdb.java/Makefile gdb.mi/Makefile gdb.modula2/Makefile \ > + gdb.fortran/Makefile gdb.server/Makefile gdb.java/Makefile \ > + gdb.mi/Makefile gdb.modula2/Makefile gdb.multi/Makefile \ > gdb.objc/Makefile gdb.opt/Makefile gdb.pascal/Makefile \ > gdb.python/Makefile gdb.reverse/Makefile \ > gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile]) > -- Pedro Alves