From: Joel Brobecker <brobecker@adacore.com>
To: Chris Moller <cmoller@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: pr 11067 patch
Date: Fri, 19 Feb 2010 14:28:00 -0000 [thread overview]
Message-ID: <20100219142846.GC2779@adacore.com> (raw)
In-Reply-To: <4B76F5CE.30704@redhat.com>
Hi Chris,
I finally had a bit of time to look at your last patch. I agree with
Jan's comments on the patch (formatting issues, mostly, right?), and
I have no other comments. The C code in the testsuite doesn't necessarily
need to follow the GCS, I think, but it's probably not much trouble
fixing it.
> This has gone way past ridiculous--it's time this whole thing was
> resolved as WONTFIX and closed.
I respect either decision you might take. Again, I feel guilty about
jumping in the discussion really late. However, I should say that I am OK
with your latest version with the little tweaks suggested by Jan, if
you want to commit that. Jan's question, IMO (Jan, please correct me if
I am wrong), were meant as a discussion starter, rather than an objection.
--
Joel
next prev parent reply other threads:[~2010-02-19 14:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 2:55 Chris Moller
2010-02-11 9:30 ` Joel Brobecker
2010-02-11 14:19 ` Chris Moller
2010-02-11 19:50 ` Tom Tromey
2010-02-12 4:11 ` Joel Brobecker
2010-02-12 15:48 ` Chris Moller
2010-02-13 11:49 ` Jan Kratochvil
2010-02-13 18:56 ` Chris Moller
2010-02-19 14:28 ` Joel Brobecker [this message]
2010-02-19 14:36 ` Jan Kratochvil
2010-02-19 14:45 ` Joel Brobecker
2010-02-19 14:54 ` Chris Moller
2010-02-19 18:50 ` Jan Kratochvil
2010-02-19 19:52 ` Chris Moller
2010-02-19 20:11 ` Jan Kratochvil
2010-02-22 9:22 ` Vladimir Prus
2010-02-23 23:55 ` Tom Tromey
2010-03-11 15:44 ` pr 11067 patch resurrected from the dead Chris Moller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219142846.GC2779@adacore.com \
--to=brobecker@adacore.com \
--cc=cmoller@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox