From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Chris Moller <cmoller@redhat.com>, gdb-patches@sourceware.org
Subject: Re: pr 11067 patch
Date: Fri, 12 Feb 2010 04:11:00 -0000 [thread overview]
Message-ID: <20100212041137.GE2907@adacore.com> (raw)
In-Reply-To: <m3wryjr1r0.fsf@fleche.redhat.com>
> If you disagree strongly, then we could just close the PR and drop it, I
> suppose. I am not very intent on this, I just thought it would be a
> nice, if minor, enhancement. I didn't see a real downside.
Not at all, I cannot say I like the idea, but if it's useful to others,
this is all that really matters. Let's go ahead, then.
Regarding GNU indent - I know. But I try to keep formatting the code
the way GNU indent would do it in sane situations, as it helps keeping
some uniformity to our code. There are some rules I don't like (ahem,
ask me about spaces and tabs), but I think that uniformity is more
important...
I'm happy I contributed just a little bit towards this patch - I really
felt bad reacting to it so so late in the game.
--
Joel
next prev parent reply other threads:[~2010-02-12 4:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 2:55 Chris Moller
2010-02-11 9:30 ` Joel Brobecker
2010-02-11 14:19 ` Chris Moller
2010-02-11 19:50 ` Tom Tromey
2010-02-12 4:11 ` Joel Brobecker [this message]
2010-02-12 15:48 ` Chris Moller
2010-02-13 11:49 ` Jan Kratochvil
2010-02-13 18:56 ` Chris Moller
2010-02-19 14:28 ` Joel Brobecker
2010-02-19 14:36 ` Jan Kratochvil
2010-02-19 14:45 ` Joel Brobecker
2010-02-19 14:54 ` Chris Moller
2010-02-19 18:50 ` Jan Kratochvil
2010-02-19 19:52 ` Chris Moller
2010-02-19 20:11 ` Jan Kratochvil
2010-02-22 9:22 ` Vladimir Prus
2010-02-23 23:55 ` Tom Tromey
2010-03-11 15:44 ` pr 11067 patch resurrected from the dead Chris Moller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212041137.GE2907@adacore.com \
--to=brobecker@adacore.com \
--cc=cmoller@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox