From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32638 invoked by alias); 12 Feb 2010 04:11:52 -0000 Received: (qmail 32629 invoked by uid 22791); 12 Feb 2010 04:11:51 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Feb 2010 04:11:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5F0482BAC23; Thu, 11 Feb 2010 23:11:46 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jdoQrVfhkykv; Thu, 11 Feb 2010 23:11:46 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DD9AB2BAC1D; Thu, 11 Feb 2010 23:11:45 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5B4E9F59AE; Fri, 12 Feb 2010 08:11:37 +0400 (RET) Date: Fri, 12 Feb 2010 04:11:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Chris Moller , gdb-patches@sourceware.org Subject: Re: pr 11067 patch Message-ID: <20100212041137.GE2907@adacore.com> References: <4B737180.4050802@redhat.com> <20100211092950.GC2907@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00314.txt.bz2 > If you disagree strongly, then we could just close the PR and drop it, I > suppose. I am not very intent on this, I just thought it would be a > nice, if minor, enhancement. I didn't see a real downside. Not at all, I cannot say I like the idea, but if it's useful to others, this is all that really matters. Let's go ahead, then. Regarding GNU indent - I know. But I try to keep formatting the code the way GNU indent would do it in sane situations, as it helps keeping some uniformity to our code. There are some rules I don't like (ahem, ask me about spaces and tabs), but I think that uniformity is more important... I'm happy I contributed just a little bit towards this patch - I really felt bad reacting to it so so late in the game. -- Joel