From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4538 invoked by alias); 19 Feb 2010 14:28:54 -0000 Received: (qmail 4530 invoked by uid 22791); 19 Feb 2010 14:28:53 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Feb 2010 14:28:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C7CC12BAC15; Fri, 19 Feb 2010 09:28:46 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jNEZ1pJtCrhI; Fri, 19 Feb 2010 09:28:46 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A81D82BAC2B; Fri, 19 Feb 2010 09:28:46 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5653DF5896; Fri, 19 Feb 2010 15:28:46 +0100 (CET) Date: Fri, 19 Feb 2010 14:28:00 -0000 From: Joel Brobecker To: Chris Moller Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: pr 11067 patch Message-ID: <20100219142846.GC2779@adacore.com> References: <4B737180.4050802@redhat.com> <20100211092950.GC2907@adacore.com> <20100212041137.GE2907@adacore.com> <4B75783D.6050103@redhat.com> <20100213114933.GA595@host0.dyn.jankratochvil.net> <4B76F5CE.30704@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B76F5CE.30704@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00483.txt.bz2 Hi Chris, I finally had a bit of time to look at your last patch. I agree with Jan's comments on the patch (formatting issues, mostly, right?), and I have no other comments. The C code in the testsuite doesn't necessarily need to follow the GCS, I think, but it's probably not much trouble fixing it. > This has gone way past ridiculous--it's time this whole thing was > resolved as WONTFIX and closed. I respect either decision you might take. Again, I feel guilty about jumping in the discussion really late. However, I should say that I am OK with your latest version with the little tweaks suggested by Jan, if you want to commit that. Jan's question, IMO (Jan, please correct me if I am wrong), were meant as a discussion starter, rather than an objection. -- Joel