Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: "H.J. Lu" <hongjiu.lu@intel.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: PR shlibs/11293: gdb is broken on Linux/i386
Date: Wed, 17 Feb 2010 20:29:00 -0000	[thread overview]
Message-ID: <20100217202944.GA20305@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20100217201031.GA24995@lucon.org>

On Wed, 17 Feb 2010 21:10:31 +0100, H.J. Lu wrote:
> ULONGEST is 64bit on Linux/i386.  We should check CORE_ADDR instead
> of ULONGEST for address size. OK to install?

# solib-svr4.c:1468: internal-error: enable_break: Assertion `load_addr < space_size' failed.

# For 32bit, addr_bit is 32 and CORE_ADDR is 4 byte.

I was regression-testing it for i386 with --enable-64-bit-bfd, sorry.


> -	    if (addr_bit < (sizeof (ULONGEST) * HOST_CHAR_BIT))
> +	    if (addr_bit < (sizeof (CORE_ADDR) * HOST_CHAR_BIT))
>  	      {
>  		CORE_ADDR space_size = (ULONGEST) 1 << addr_bit;
>  		CORE_ADDR tmp_entry_point = exec_entry_point (tmp_bfd,

This code in GDB commonly uses even:
 		CORE_ADDR space_size = (CORE_ADDR) 1 << addr_bit;

I copied it from a wrong place.

Yes, I agree with your fix (this is not an approval).


Thanks,
Jan


  reply	other threads:[~2010-02-17 20:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 20:10 H.J. Lu
2010-02-17 20:29 ` Jan Kratochvil [this message]
2010-02-17 20:33 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100217202944.GA20305@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hongjiu.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox