From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22999 invoked by alias); 17 Feb 2010 20:29:53 -0000 Received: (qmail 22985 invoked by uid 22791); 17 Feb 2010 20:29:53 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Feb 2010 20:29:49 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1HKTm7h023249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Feb 2010 15:29:48 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1HKTjpj029525 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 17 Feb 2010 15:29:47 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o1HKTjOw020532; Wed, 17 Feb 2010 21:29:45 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o1HKTi1F020531; Wed, 17 Feb 2010 21:29:44 +0100 Date: Wed, 17 Feb 2010 20:29:00 -0000 From: Jan Kratochvil To: "H.J. Lu" Cc: GDB Subject: Re: PATCH: PR shlibs/11293: gdb is broken on Linux/i386 Message-ID: <20100217202944.GA20305@host0.dyn.jankratochvil.net> References: <20100217201031.GA24995@lucon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100217201031.GA24995@lucon.org> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00441.txt.bz2 On Wed, 17 Feb 2010 21:10:31 +0100, H.J. Lu wrote: > ULONGEST is 64bit on Linux/i386. We should check CORE_ADDR instead > of ULONGEST for address size. OK to install? # solib-svr4.c:1468: internal-error: enable_break: Assertion `load_addr < space_size' failed. # For 32bit, addr_bit is 32 and CORE_ADDR is 4 byte. I was regression-testing it for i386 with --enable-64-bit-bfd, sorry. > - if (addr_bit < (sizeof (ULONGEST) * HOST_CHAR_BIT)) > + if (addr_bit < (sizeof (CORE_ADDR) * HOST_CHAR_BIT)) > { > CORE_ADDR space_size = (ULONGEST) 1 << addr_bit; > CORE_ADDR tmp_entry_point = exec_entry_point (tmp_bfd, This code in GDB commonly uses even: CORE_ADDR space_size = (CORE_ADDR) 1 << addr_bit; I copied it from a wrong place. Yes, I agree with your fix (this is not an approval). Thanks, Jan