From: "H.J. Lu" <hongjiu.lu@intel.com>
To: GDB <gdb-patches@sourceware.org>
Subject: PATCH: PR shlibs/11293: gdb is broken on Linux/i386
Date: Wed, 17 Feb 2010 20:10:00 -0000 [thread overview]
Message-ID: <20100217201031.GA24995@lucon.org> (raw)
Hi,
ULONGEST is 64bit on Linux/i386. We should check CORE_ADDR instead
of ULONGEST for address size. OK to install?
Thanks.
H.J.
--
2010-02-17 H.J. Lu <hongjiu.lu@intel.com>
PR shlibs/11293
* solib-svr4.c (enable_break): Check size of CORE_ADDR instead
of ULONGEST for address size.
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index b3b9e00..f4fccb2 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -1459,7 +1459,7 @@ enable_break (struct svr4_info *info, int from_tty)
invalid addresses like 0x101234567 for 32bit inferiors on 64bit
GDB. */
- if (addr_bit < (sizeof (ULONGEST) * HOST_CHAR_BIT))
+ if (addr_bit < (sizeof (CORE_ADDR) * HOST_CHAR_BIT))
{
CORE_ADDR space_size = (ULONGEST) 1 << addr_bit;
CORE_ADDR tmp_entry_point = exec_entry_point (tmp_bfd,
next reply other threads:[~2010-02-17 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 20:10 H.J. Lu [this message]
2010-02-17 20:29 ` Jan Kratochvil
2010-02-17 20:33 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217201031.GA24995@lucon.org \
--to=hongjiu.lu@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox