From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/doco/testsuite] Document new gdb_test_timeout global variable.
Date: Tue, 09 Feb 2010 13:10:00 -0000 [thread overview]
Message-ID: <20100209131015.GH16325@adacore.com> (raw)
In-Reply-To: <83eikvegcs.fsf@gnu.org>
> > +If not specifically defined, this variable gets automatically defined
> > +to the same value as @code{timeout} during the testsuite initialization
> > +(the actual value depends on the exact running parameters).
>
> It would be worth saying more about how to find out the default
> value. If I'm a reader of this section, I might ask myself whether I
> need to set the variable to a non-default value, but it is impossible
> to answer that question without knowing what would be the value if I
> don't do anything.
The problem is that this is tricky and really depends a lot on whether
the user uses a board file or not, since dejagnu is so configurable
(you should see the list of files that get loaded at startup). I'm not
even certain that *I* know the entire story: As far as I can tell,
gdb/testsuite/config/unix.exp sets a timeout of 60 seconds. I don't
think we set the timeout anywhere else. So that leaves the question
of board files. If the user used board files, then they may or may not
have also set the timeout there.
On the other hand, one easy way to determine the default timeout is
just to add a trace in one testcase that prints it. Crude, but
effective, since this is how I noticed that the default timeout was
not the value that I thought it would be (and hence ended up noticing
the change in unix.exp, only after some heavy grepping).
So what should do we do in this case? I've fixed all the other nits
that you mentioned, except this... Perhaps we should just refer the user
to the dejagnu documentation somewhere earlier.
--
Joel
next prev parent reply other threads:[~2010-02-09 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 12:17 Joel Brobecker
2010-02-08 18:24 ` Eli Zaretskii
2010-02-09 13:10 ` Joel Brobecker [this message]
2010-02-09 18:44 ` Eli Zaretskii
2010-02-11 7:52 ` Joel Brobecker
2010-02-11 18:43 ` Eli Zaretskii
2010-02-12 4:49 ` Joel Brobecker
2010-02-12 10:05 ` Eli Zaretskii
2010-02-13 4:57 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100209131015.GH16325@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox