From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3965 invoked by alias); 9 Feb 2010 13:10:35 -0000 Received: (qmail 3865 invoked by uid 22791); 9 Feb 2010 13:10:35 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Feb 2010 13:10:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A6AD72BABF0; Tue, 9 Feb 2010 08:10:29 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CvCQE27lWEeP; Tue, 9 Feb 2010 08:10:29 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F3A352BAC02; Tue, 9 Feb 2010 08:10:28 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A0050F59A2; Tue, 9 Feb 2010 17:10:15 +0400 (RET) Date: Tue, 09 Feb 2010 13:10:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA/doco/testsuite] Document new gdb_test_timeout global variable. Message-ID: <20100209131015.GH16325@adacore.com> References: <1265631452-2476-1-git-send-email-brobecker@adacore.com> <83eikvegcs.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83eikvegcs.fsf@gnu.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00254.txt.bz2 > > +If not specifically defined, this variable gets automatically defined > > +to the same value as @code{timeout} during the testsuite initialization > > +(the actual value depends on the exact running parameters). > > It would be worth saying more about how to find out the default > value. If I'm a reader of this section, I might ask myself whether I > need to set the variable to a non-default value, but it is impossible > to answer that question without knowing what would be the value if I > don't do anything. The problem is that this is tricky and really depends a lot on whether the user uses a board file or not, since dejagnu is so configurable (you should see the list of files that get loaded at startup). I'm not even certain that *I* know the entire story: As far as I can tell, gdb/testsuite/config/unix.exp sets a timeout of 60 seconds. I don't think we set the timeout anywhere else. So that leaves the question of board files. If the user used board files, then they may or may not have also set the timeout there. On the other hand, one easy way to determine the default timeout is just to add a trace in one testcase that prints it. Crude, but effective, since this is how I noticed that the default timeout was not the value that I thought it would be (and hence ended up noticing the change in unix.exp, only after some heavy grepping). So what should do we do in this case? I've fixed all the other nits that you mentioned, except this... Perhaps we should just refer the user to the dejagnu documentation somewhere earlier. -- Joel