Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/doco/testsuite] Document new gdb_test_timeout global variable.
Date: Mon, 08 Feb 2010 18:24:00 -0000	[thread overview]
Message-ID: <83eikvegcs.fsf@gnu.org> (raw)
In-Reply-To: <1265631452-2476-1-git-send-email-brobecker@adacore.com>

> From: Joel Brobecker <brobecker@adacore.com>
> Date: Mon,  8 Feb 2010 16:17:32 +0400
> 
> This patch documents a new testsuite variable introduced to allow
> the user to configure the timeout duration used while running
> the testsuite.
> 
>     http://www.sourceware.org/ml/gdb-patches/2010-02/msg00101.html
> 
> gdb/doc/ChangeLog:
> 
>         * gdbint.texinfo (Testsuite): New section "Testsuite Configuration",
>         documenting the gdb_test_timeout variable.

Thanks.

> +@section Testsuite Configuration

It's usually a good idea to put a @cindex entry with the same text as
the name of the section (with all words lower-cased) right after the
section header.  That is because most section names introduce a topic,
and users looking for that info will likely think about that topic as
well.

> +It is possible to adjust the behavior of the testsuite by defining
> +the global variables listed below, either in a @file{site.exp} file,
> +or in a @code{board} file.

Why "board" is in @code, not in @file?  Isn't it a file?

> +If not specifically defined, this variable gets automatically defined
> +to the same value as @code{timeout} during the testsuite initialization
> +(the actual value depends on the exact running parameters).

It would be worth saying more about how to find out the default
value.  If I'm a reader of this section, I might ask myself whether I
need to set the variable to a non-default value, but it is impossible
to answer that question without knowing what would be the value if I
don't do anything.

> +This global variable is usually used when the debugger is slower than

"usually used" sounds awkward.  How about "comes in handy"?

> +test failures.  For instance, when testing on a remote machine, or against
> +a system where communications are slow.

The last sentence is not a complete one.  How about

  Examples include testing on a remote ...

?


  reply	other threads:[~2010-02-08 18:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-08 12:17 Joel Brobecker
2010-02-08 18:24 ` Eli Zaretskii [this message]
2010-02-09 13:10   ` Joel Brobecker
2010-02-09 18:44     ` Eli Zaretskii
2010-02-11  7:52       ` Joel Brobecker
2010-02-11 18:43         ` Eli Zaretskii
2010-02-12  4:49           ` Joel Brobecker
2010-02-12 10:05             ` Eli Zaretskii
2010-02-13  4:57               ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eikvegcs.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox