Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, "H.J. Lu" <hjl.tools@gmail.com>,
		GDB <gdb@sourceware.org>
Subject: Re: [patch] Fix CLONE_VM vs. TLS  [Re: Is CLONE_VM really needed   in   gdbserver?]
Date: Fri, 29 Jan 2010 02:30:00 -0000	[thread overview]
Message-ID: <20100129023040.GA20267@caradoc.them.org> (raw)
In-Reply-To: <20100129012625.GA8631@host0.dyn.jankratochvil.net>

On Fri, Jan 29, 2010 at 02:26:25AM +0100, Jan Kratochvil wrote:
> CodeSourcery arm-2009q3-66-arm-uclinuxeabi-i686-pc-linux-gnu.tar.bz2 gcc sets
> __uClinux__ although gdb/gdbserver/linux-low.c depends on __UCLIBC__.
> CLONE_VM is a kernel feature so gcc should be more appropriate but maybe it
> does not matter.

It's the __UCLIBC_HAS_MMU__ / __ARCH_HAS_MMU__ that make this OK; the end
result is functionally equivalent to a __uClinux__ check.  uClibc can
be used on full Linux too, and there you have fork.

> 
> 
> Thanks,
> Jan
> 
> 
> gdb/gdbserver/
> 2010-01-29  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	PR libc/11214:
> 	* linux-low.c (linux_tracefork_child) [!(__UCLIBC__ && HAS_NOMMU)]: New.
> 	(linux_test_for_tracefork): Move `stack' into [__UCLIBC__ && HAS_NOMMU].
> 	(linux_test_for_tracefork) [!(__UCLIBC__ && HAS_NOMMU)]: New.
> 
> gdb/testsuite/
> 2010-01-29  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	PR libc/11214:
> 	* gdb.threads/current-lwp-dead.c (fn, main): Move CLONE_VM into
> 	[__uClinux__].

OK.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2010-01-29  2:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6dc9ffc81001261551j6221db6v88e96713d6dd9497@mail.gmail.com>
     [not found] ` <20100127000821.GA29862@caradoc.them.org>
2010-01-27 22:12   ` Jan Kratochvil
2010-01-28 16:22     ` H.J. Lu
2010-01-28 17:01     ` Daniel Jacobowitz
2010-01-29  1:26       ` Jan Kratochvil
2010-01-29  2:30         ` Daniel Jacobowitz [this message]
2010-01-29 12:41           ` Jan Kratochvil
2010-02-01 20:20             ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100129023040.GA20267@caradoc.them.org \
    --to=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox