From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1125 invoked by alias); 29 Jan 2010 02:30:54 -0000 Received: (qmail 863 invoked by uid 22791); 29 Jan 2010 02:30:53 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 Jan 2010 02:30:47 +0000 Received: (qmail 1079 invoked from network); 29 Jan 2010 02:30:46 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Jan 2010 02:30:46 -0000 Date: Fri, 29 Jan 2010 02:30:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sourceware.org, "H.J. Lu" , GDB Subject: Re: [patch] Fix CLONE_VM vs. TLS [Re: Is CLONE_VM really needed in gdbserver?] Message-ID: <20100129023040.GA20267@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org, "H.J. Lu" , GDB References: <6dc9ffc81001261551j6221db6v88e96713d6dd9497@mail.gmail.com> <20100127000821.GA29862@caradoc.them.org> <20100127221236.GA4746@host0.dyn.jankratochvil.net> <20100128170103.GA9936@caradoc.them.org> <20100129012625.GA8631@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100129012625.GA8631@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00628.txt.bz2 On Fri, Jan 29, 2010 at 02:26:25AM +0100, Jan Kratochvil wrote: > CodeSourcery arm-2009q3-66-arm-uclinuxeabi-i686-pc-linux-gnu.tar.bz2 gcc sets > __uClinux__ although gdb/gdbserver/linux-low.c depends on __UCLIBC__. > CLONE_VM is a kernel feature so gcc should be more appropriate but maybe it > does not matter. It's the __UCLIBC_HAS_MMU__ / __ARCH_HAS_MMU__ that make this OK; the end result is functionally equivalent to a __uClinux__ check. uClibc can be used on full Linux too, and there you have fork. > > > Thanks, > Jan > > > gdb/gdbserver/ > 2010-01-29 Jan Kratochvil > > PR libc/11214: > * linux-low.c (linux_tracefork_child) [!(__UCLIBC__ && HAS_NOMMU)]: New. > (linux_test_for_tracefork): Move `stack' into [__UCLIBC__ && HAS_NOMMU]. > (linux_test_for_tracefork) [!(__UCLIBC__ && HAS_NOMMU)]: New. > > gdb/testsuite/ > 2010-01-29 Jan Kratochvil > > PR libc/11214: > * gdb.threads/current-lwp-dead.c (fn, main): Move CLONE_VM into > [__uClinux__]. OK. -- Daniel Jacobowitz CodeSourcery