From: Joel Brobecker <brobecker@adacore.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org, Luis Machado <luisgpm@linux.vnet.ibm.com>
Subject: Re: [RFA] Fix verification of changed values for big values.
Date: Wed, 30 Dec 2009 19:22:00 -0000 [thread overview]
Message-ID: <20091230192123.GH2788@adacore.com> (raw)
In-Reply-To: <200912301538.04119.bauerman@br.ibm.com>
> The purpose of the function is rather simple, so I didn't have much to say.
> I added this description:
>
> /* Evaluate watchpoint condition expression and check if its value changed. */
Thanks. I thought it was important to explain what the real type of
parameter P was so I added an extra sentence to the documentation.
Patch attached.
> You're right. IIRC I used gdb_expect because I wanted to explicitly check
> for the gdb prompt in my regex, to avoid it being too greedy.
Just for the fun of discussion (I am French, after all :-), I am
pretty sure that you can also do that with gdb_test_multiple...
--
Joel
next prev parent reply other threads:[~2009-12-30 19:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 23:43 Thiago Jung Bauermann
2009-12-24 4:41 ` Joel Brobecker
2009-12-30 17:38 ` Thiago Jung Bauermann
2009-12-30 19:22 ` Joel Brobecker [this message]
2009-12-30 19:48 ` Joel Brobecker
2009-12-30 20:00 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091230192123.GH2788@adacore.com \
--to=brobecker@adacore.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox