Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sourceware.org, Luis Machado <luisgpm@linux.vnet.ibm.com>
Subject: Re: [RFA] Fix verification of changed values for big values.
Date: Wed, 30 Dec 2009 19:48:00 -0000	[thread overview]
Message-ID: <20091230194750.GI2788@adacore.com> (raw)
In-Reply-To: <20091230192123.GH2788@adacore.com>

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

> Patch attached.

[trying to fight sleepiness.......]

2009-12-30  Joel Brobecker  <brobecker@adacore.com>

        * breakpoint.c (watchpoint_check): Expand the function description.

-- 
Joel

[-- Attachment #2: bp-comment.diff --]
[-- Type: text/x-diff, Size: 738 bytes --]

Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.443
diff -u -p -r1.443 breakpoint.c
--- breakpoint.c	30 Dec 2009 17:33:33 -0000	1.443
+++ breakpoint.c	30 Dec 2009 19:13:44 -0000
@@ -3174,7 +3174,10 @@ watchpoints_triggered (struct target_wai
 #define BP_TEMPFLAG 1
 #define BP_HARDWAREFLAG 2
 
-/* Evaluate watchpoint condition expression and check if its value changed.  */
+/* Evaluate watchpoint condition expression and check if its value changed.
+
+   P should be a pointer to struct bpstat, but is defined as a void *
+   in order for this function to be usable with catch_errors.  */
 
 static int
 watchpoint_check (void *p)

  reply	other threads:[~2009-12-30 19:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 23:43 Thiago Jung Bauermann
2009-12-24  4:41 ` Joel Brobecker
2009-12-30 17:38   ` Thiago Jung Bauermann
2009-12-30 19:22     ` Joel Brobecker
2009-12-30 19:48       ` Joel Brobecker [this message]
2009-12-30 20:00       ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091230194750.GI2788@adacore.com \
    --to=brobecker@adacore.com \
    --cc=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luisgpm@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox