Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Ian Lance Taylor <iant@google.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
	brobecker@adacore.com, 	gdb-patches@sourceware.org
Subject: Re: [RFC] frame_id_inner check and -fsplit-stack
Date: Wed, 30 Dec 2009 13:45:00 -0000	[thread overview]
Message-ID: <20091230134517.GA14669@caradoc.them.org> (raw)
In-Reply-To: <m3eimclwcu.fsf@pepe.airs.com>

On Wed, Dec 30, 2009 at 12:06:09AM -0800, Ian Lance Taylor wrote:
> Looking at DWARF, I see that there is a calling_convention enum which
> can be added to the DW_TAG_subprogram for a function.  I don't know all
> that much about DWARF; does that seem like the right sort of thing to
> do?

No.  The split-stack-ness doesn't affect how the function is called;
the attribute's for cases like regparm.

> That wouldn't help with the unwind info, though.  There I think we could
> add a new augmentation code for a split-stack function.  The presence of
> the augmentation would mean that the stack might be out of order when
> unwinding through this function.  I think that would work because
> unwinders which didn't recognize it would simply ignore it.  But again I
> am far from being an expert in this area.

An augmentation ought to work for this.  Similarly, GDB could check
for the prologue sequence if there is no unwind info.

Didn't we have another report that the inner-than check was causing
trouble, just a few months ago?  I think it had to do with the Linux
kernel, but I can't find the details.  This check causes a lot of
trouble.

-- 
Daniel Jacobowitz
CodeSourcery


      parent reply	other threads:[~2009-12-30 13:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-29 19:07 Joel Brobecker
2009-12-29 19:49 ` Mark Kettenis
2009-12-30  8:06   ` Ian Lance Taylor
2009-12-30  8:58     ` Joel Brobecker
2009-12-30 13:45     ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091230134517.GA14669@caradoc.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=iant@google.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox