Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ian Lance Taylor <iant@google.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [RFC] frame_id_inner check and -fsplit-stack
Date: Wed, 30 Dec 2009 08:58:00 -0000	[thread overview]
Message-ID: <20091230085750.GE2788@adacore.com> (raw)
In-Reply-To: <m3eimclwcu.fsf@pepe.airs.com>

> > I think we shouldn't add a knob if we don't need to.  So I'd say we
> > defenitely should try (4).  My initial idea for implementing this
> > would be for the unwinder to mark the frames that "split" the stack
> > (i.e. make the not normal), and skip the check for those frames.  I
> > also think the information should be encoded in the debug information
> > instead of magic section names that could be lost during (re)linking.
> 
> Looking at DWARF, I see that there is a calling_convention enum which
> can be added to the DW_TAG_subprogram for a function.  I don't know all
> that much about DWARF; does that seem like the right sort of thing to
> do?

As mentioned to Ian on IRC, the downside of this approach is that
the information would not be available unless the code was compiled
with debugging info. I think that this is a serious enough downside
that we should try to avoid it if possible.

> That wouldn't help with the unwind info, though.  There I think we could
> add a new augmentation code for a split-stack function.

I'm not a specialist of unwind info either.  But I think that this
approach, if implementable, would be more robust.

-- 
Joel


  reply	other threads:[~2009-12-30  8:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-29 19:07 Joel Brobecker
2009-12-29 19:49 ` Mark Kettenis
2009-12-30  8:06   ` Ian Lance Taylor
2009-12-30  8:58     ` Joel Brobecker [this message]
2009-12-30 13:45     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091230085750.GE2788@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=iant@google.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox