From: Joel Brobecker <brobecker@adacore.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Add support for Renesas RX architecture
Date: Fri, 04 Dec 2009 17:38:00 -0000 [thread overview]
Message-ID: <20091204173837.GD2891@adacore.com> (raw)
In-Reply-To: <20091203161906.7f7a6c06@redhat.com>
> I'll note up front that there's one #if 0 in rx-tdep.c. I'd prefer to
> leave it there until Nick and I get all of the kinks worked out of
> the debug info. I'm willing to remove it though if there are objections
> to having it in new code.
I usually prefer to avoid #if 0 code, but the comment is definitely
useful. In this particular case, I don't think it's so bad, although,
IMO, the same effect could have been achieved without the #if 0, just
the comment (enabling the dwarf2 unwinders is standard, so it's not
like we need the reminder). Anyway, I'm personally OK, since I presume
that this in the TODO list to get fixed as some point in the near/medium
future.
> Comments?
>
> * configure.tgt: Add rx-*-elf target.
> * rx-tdep.c: New target.
Yes. Great code, very clean. Please go ahead and commit. I think this
also deserves a NEWS entry (you can send it as a separate patch for Eli).
Nice to see someone using the prologue-value infrastructure too, btw.
--
Joel
next prev parent reply other threads:[~2009-12-04 17:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 23:19 Kevin Buettner
2009-12-04 17:38 ` Joel Brobecker [this message]
2009-12-07 20:39 ` Kevin Buettner
2009-12-07 20:56 ` Daniel Jacobowitz
2009-12-07 21:21 ` DJ Delorie
2009-12-07 21:29 ` Daniel Jacobowitz
2009-12-07 21:42 ` DJ Delorie
2009-12-07 22:36 ` Doug Evans
2009-12-07 23:20 ` DJ Delorie
2009-12-08 2:01 ` Doug Evans
2009-12-07 22:10 ` Michael Snyder
2009-12-07 22:38 ` Doug Evans
2009-12-07 20:00 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204173837.GD2891@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox