From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15278 invoked by alias); 4 Dec 2009 17:38:48 -0000 Received: (qmail 15270 invoked by uid 22791); 4 Dec 2009 17:38:48 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Dec 2009 17:38:42 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 28C462BAC22; Fri, 4 Dec 2009 12:38:41 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Twb8-oTyZLoa; Fri, 4 Dec 2009 12:38:41 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E76542BAB8D; Fri, 4 Dec 2009 12:38:40 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C7546F588A; Fri, 4 Dec 2009 09:38:37 -0800 (PST) Date: Fri, 04 Dec 2009 17:38:00 -0000 From: Joel Brobecker To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Add support for Renesas RX architecture Message-ID: <20091204173837.GD2891@adacore.com> References: <20091203161906.7f7a6c06@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091203161906.7f7a6c06@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00059.txt.bz2 > I'll note up front that there's one #if 0 in rx-tdep.c. I'd prefer to > leave it there until Nick and I get all of the kinks worked out of > the debug info. I'm willing to remove it though if there are objections > to having it in new code. I usually prefer to avoid #if 0 code, but the comment is definitely useful. In this particular case, I don't think it's so bad, although, IMO, the same effect could have been achieved without the #if 0, just the comment (enabling the dwarf2 unwinders is standard, so it's not like we need the reminder). Anyway, I'm personally OK, since I presume that this in the TODO list to get fixed as some point in the near/medium future. > Comments? > > * configure.tgt: Add rx-*-elf target. > * rx-tdep.c: New target. Yes. Great code, very clean. Please go ahead and commit. I think this also deserves a NEWS entry (you can send it as a separate patch for Eli). Nice to see someone using the prologue-value infrastructure too, btw. -- Joel