Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: DJ Delorie <dj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Add support for Renesas RX architecture
Date: Tue, 08 Dec 2009 02:01:00 -0000	[thread overview]
Message-ID: <e394668d0912071801i39959f8x3af936af797d4f09@mail.gmail.com> (raw)
In-Reply-To: <200912072319.nB7NJmV3025955@greed.delorie.com>

On Mon, Dec 7, 2009 at 3:19 PM, DJ Delorie <dj@redhat.com> wrote:
>
>> Rather, it's that such support was always planned, it just needed
>> someone to add it.
>
> For the record, here's the limitations I've found...
>
> * The opcode descriptions are generated by exploding macros to get all
>  the prefix/operand byte permutations (about 12,000 total).  I.e. a
>  single variable-length opcode is converted into dozens of
>  fixed-length opcodes.  Regenerating takes about an hour, and
>  maintenance is a nightmare.

That was always just a temp hack until var-length support was complete.
[at which time, btw, cgen will no longer be responsible for 4MB source
files in opcodes :-)]

btw, for reference sake, some basic changes in cgen's data structures
brought the time down for m32c from 30mins to 5mins last time I
visited this.  It's still too long, and more can be done, but it was
easy to do.

> * cgen doesn't handle the opcode-vs-decodable bits in m32c very well.
>  The hash table has nothing left to work with (every bit is an
>  operand in *some* opcode), so the disassembler takes a noticably
>  long time starting up, especially given that the exploding macros
>  create many opcodes to hash.

I can't imagine there being anything inherent in cgen that prohibits a solution.
If a hash table isn't the best tool for a particular port, we can add
something that is.

> * The disassembler always reads MAX(opsize) bytes, so the .text
>  sections have to be padded with NOP bytes to prevent crashes.

Ditto.


  reply	other threads:[~2009-12-08  2:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03 23:19 Kevin Buettner
2009-12-04 17:38 ` Joel Brobecker
2009-12-07 20:39   ` Kevin Buettner
2009-12-07 20:56     ` Daniel Jacobowitz
2009-12-07 21:21       ` DJ Delorie
2009-12-07 21:29         ` Daniel Jacobowitz
2009-12-07 21:42           ` DJ Delorie
2009-12-07 22:36             ` Doug Evans
2009-12-07 23:20               ` DJ Delorie
2009-12-08  2:01                 ` Doug Evans [this message]
2009-12-07 22:10       ` Michael Snyder
2009-12-07 22:38         ` Doug Evans
2009-12-07 20:00 ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e394668d0912071801i39959f8x3af936af797d4f09@mail.gmail.com \
    --to=dje@google.com \
    --cc=dj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox