From: Pedro Alves <pedro@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] cleanup: Remove INVALID_ENTRY_POINT (+FR-V modification)
Date: Sat, 31 Oct 2009 21:07:00 -0000 [thread overview]
Message-ID: <200910312108.28983.pedro@codesourcery.com> (raw)
In-Reply-To: <20091031195053.GA9955@host0.dyn.jankratochvil.net>
On Saturday 31 October 2009 19:50:53, Jan Kratochvil wrote:
> > /* If there's a valid and known entry point, fills ENTRY_P with it
> > and return true; otherwise return false. */
> > int entry_point_address (CORE_ADDR *entry_p);
>
> Used this one + an error()-calling wrapper.
Nice, thanks.
> 2009-10-31 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Remove INVALID_ENTRY_POINT.
> * frame.c (inside_entry_func): New variable entry_point. Return 0 if
> the entry point is not known.
> * solib-irix.c (enable_break): Likewise.
> * objfiles.c (init_entry_point_info): Stop using INVALID_ENTRY_POINT.
> Initialize EI.ENTRY_POINT_P.
> (entry_point_address): Rename to ...
> (entry_point_address_query): ... a new function. Use EI.ENTRY_POINT_P.
> (entry_point_address): New function.
> (objfile_relocate): Use EI.ENTRY_POINT_P.
> * objfiles.h (struct entry_info): Simplify entry_point comment. New
> field entry_point_p.
> (INVALID_ENTRY_POINT): Remove.
> (entry_point_address_query): New prototype.
> * solib-frv.c (enable_break): Check for NULL SYMFILE_OBJFILE and its
> EI.ENTRY_POINT_P. Return 0 if ".interp" is not found.
Looks OK to me.
--
Pedro Alves
next prev parent reply other threads:[~2009-10-31 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 15:08 Jan Kratochvil
2009-10-31 15:41 ` Pedro Alves
2009-10-31 19:51 ` Jan Kratochvil
2009-10-31 21:07 ` Pedro Alves [this message]
2009-11-02 14:51 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910312108.28983.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox