Re: [patch] cleanup: Remove INVALID_ENTRY_POINT (+FR-V modification)

[Pedro Alves <pedro@codesourcery.com>]

On Saturday 31 October 2009 15:08:29, Jan Kratochvil wrote:
> @@ -316,7 +320,7 @@ entry_point_address (void)
>    struct gdbarch *gdbarch;
>    CORE_ADDR entry_point;
>  
> -  if (symfile_objfile == NULL)
> +  if (symfile_objfile == NULL || !symfile_objfile->ei.entry_point_p)
>      return 0;

Previously, when we had a main symbol file, but the entry point was
invalid (how common is that?), we'd return ~0 here, but now we'll
return 0.  Is there potential for breakage?  inside_entry_func for
instance could trigger false positives more often.  Makes me wonder about
exposing the invalid-entry-point-ity to callers.  Say, by adding a new
entry_point_address_p(), or better, adjusting the interface to:

 /* If there's a valid and known entry point, fills ENTRY_P with it
    and return true; otherwise return false.  */
 int entry_point_address (CORE_ADDR *entry_p);

Otherwise looks ok to me.

-- 
Pedro Alves