From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23692 invoked by alias); 31 Oct 2009 21:07:53 -0000 Received: (qmail 23683 invoked by uid 22791); 31 Oct 2009 21:07:53 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 31 Oct 2009 21:07:49 +0000 Received: (qmail 32012 invoked from network); 31 Oct 2009 21:07:47 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 31 Oct 2009 21:07:47 -0000 From: Pedro Alves To: Jan Kratochvil Subject: Re: [patch] cleanup: Remove INVALID_ENTRY_POINT (+FR-V modification) Date: Sat, 31 Oct 2009 21:07:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <20091031150829.GA27608@host0.dyn.jankratochvil.net> <200910311542.13318.pedro@codesourcery.com> <20091031195053.GA9955@host0.dyn.jankratochvil.net> In-Reply-To: <20091031195053.GA9955@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910312108.28983.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00712.txt.bz2 On Saturday 31 October 2009 19:50:53, Jan Kratochvil wrote: > > /* If there's a valid and known entry point, fills ENTRY_P with it > > and return true; otherwise return false. */ > > int entry_point_address (CORE_ADDR *entry_p); > > Used this one + an error()-calling wrapper. Nice, thanks. > 2009-10-31 Jan Kratochvil > > Remove INVALID_ENTRY_POINT. > * frame.c (inside_entry_func): New variable entry_point. Return 0 if > the entry point is not known. > * solib-irix.c (enable_break): Likewise. > * objfiles.c (init_entry_point_info): Stop using INVALID_ENTRY_POINT. > Initialize EI.ENTRY_POINT_P. > (entry_point_address): Rename to ... > (entry_point_address_query): ... a new function. Use EI.ENTRY_POINT_P. > (entry_point_address): New function. > (objfile_relocate): Use EI.ENTRY_POINT_P. > * objfiles.h (struct entry_info): Simplify entry_point comment. New > field entry_point_p. > (INVALID_ENTRY_POINT): Remove. > (entry_point_address_query): New prototype. > * solib-frv.c (enable_break): Check for NULL SYMFILE_OBJFILE and its > EI.ENTRY_POINT_P. Return 0 if ".interp" is not found. Looks OK to me. -- Pedro Alves