From: Joel Brobecker <brobecker@adacore.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>,
tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFC][patch] Allow to disassemble line.
Date: Mon, 19 Oct 2009 19:40:00 -0000 [thread overview]
Message-ID: <20091019194030.GB5282@adacore.com> (raw)
In-Reply-To: <20091019184853.GA18564@caradoc.them.org>
> For whatever it's worth, I miss the extra screen real estate stolen by
> the enlarged prompt (or even the narrower prompt). I use a wider than
> average terminal and most of the times I use disassemble it still runs
> off the right and wraps unreadably. It's fine in examples because
> they have names like "gdb_main" or "bar"...
Same complaint here...
> We've got this layout here with nicely aligned columns but tons of
> whitespace. In a halfway modern world we could do this with color.
> Or bold the address of the current instruction. This would be a real
> interface departure for GDB so I'm curious what others think of it.
> (Yes, I'm thinking of Tufte, why do you ask?)
Wouldn't it be a problem with targets using MI? Or IDEs that run
GDB through a pipe (thinking of Windows in this case)?
I love the idea of starting to take advantage of the terminal capabilities
in order to introduce font properties such as colors or boldness.
> (top) disas
> Dump of assembler code for function gdb_main:
> 0x0000000000454c9e (+0): push %rbp
> 0x0000000000454c9f (+1): mov %rsp,%rbp
Regardless of the above, this suggestion seems fine to me. The repeated
function name has always been clutter (more of the time, I disass the
current function, and I know what it is :-).
> (gdb) x/2i main
> Dump of assembler code for function main:
> 0x44cce0 (+0): sub $0x28,%rsp
> 0x44cce4 (+4): movq $0x0,(%rsp)
This one is a little less obviously nice. I have little user-define
functions such as "ssi" which does "stepi; x /i $pc". Having the
output fit in a couple of lines would really add clutter in this case
(IMO).
> I do observe that disassemble prints leading zeros and examine strips them.
We could start with that...
--
Joel
next prev parent reply other threads:[~2009-10-19 19:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 0:50 Paul Pluzhnikov
2009-10-02 6:52 ` Joel Brobecker
2009-10-02 18:31 ` Paul Pluzhnikov
2009-10-02 18:49 ` Joel Brobecker
2009-10-02 15:17 ` Tom Tromey
2009-10-08 16:16 ` Paul Pluzhnikov
2009-10-08 16:23 ` Daniel Jacobowitz
2009-10-08 16:25 ` Joel Brobecker
2009-10-08 16:52 ` Paul Pluzhnikov
2009-10-08 17:29 ` Daniel Jacobowitz
2009-10-08 17:33 ` Joel Brobecker
2009-10-16 23:07 ` Paul Pluzhnikov
2009-10-16 23:11 ` Paul Pluzhnikov
2009-10-17 8:33 ` Eli Zaretskii
2009-10-17 15:50 ` Paul Pluzhnikov
2009-10-17 16:49 ` Eli Zaretskii
2009-10-17 17:08 ` Paul Pluzhnikov
2009-10-17 19:55 ` Eli Zaretskii
2009-10-19 17:47 ` Tom Tromey
2009-10-19 18:09 ` Paul Pluzhnikov
2009-10-19 18:20 ` Paul Pluzhnikov
2009-10-19 18:30 ` Tom Tromey
2009-10-21 0:22 ` Paul Pluzhnikov
2009-10-21 4:07 ` Eli Zaretskii
2009-10-21 18:06 ` Paul Pluzhnikov
2009-10-21 18:16 ` Eli Zaretskii
2009-10-21 17:24 ` Tom Tromey
2009-10-19 18:49 ` Daniel Jacobowitz
2009-10-19 19:40 ` Joel Brobecker [this message]
2009-10-19 19:56 ` Daniel Jacobowitz
2009-10-19 20:03 ` Tom Tromey
2009-10-19 20:10 ` Joel Brobecker
2009-10-19 20:23 ` Paul Pluzhnikov
2009-10-19 20:47 ` Daniel Jacobowitz
2009-10-19 19:40 ` Eli Zaretskii
2009-10-19 19:55 ` Daniel Jacobowitz
2009-10-20 16:04 ` Tom Tromey
2009-10-08 16:24 ` Joel Brobecker
2009-10-08 17:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019194030.GB5282@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox