Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC][patch] Allow to disassemble line.
Date: Thu, 08 Oct 2009 16:23:00 -0000	[thread overview]
Message-ID: <20091008162350.GA8625@caradoc.them.org> (raw)
In-Reply-To: <8ac60eac0910080916i5a2eb49an5f21f3b5c7fb96ef@mail.gmail.com>

On Thu, Oct 08, 2009 at 09:16:23AM -0700, Paul Pluzhnikov wrote:
> On Thu, Oct 1, 2009 at 5:49 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> 
> > P.S. With 'set disassemble-next-line on', current GDB appears to not work
> > as described in the manual. In particular, the manual for it says:
> >
> >   If ON, GDB will display disassembly of the next source line when
> >   execution of the program being debugged stops.
> >
> > But what GDB actually does is disassemble from *current instruction* to the
> > end of line.
> >
> > If the reason for stopping is a breakpoint on the given line, then the
> > end result is the same either way. If the reason for stopping is a crash,
> > then you get disassembly only from crash point to end of line.
> >
> > I think it's reasonable for GDB to behave either way. If it should
> > disassemble the *entire* current line, this code should be unified with
> > my patch. If the current behavior is more desirable, the manual should
> > be fixed instead.
> 
> Does anybody have an opinion on whether the implementation should be
> changed to match the manual, or vice versa?

I agree that both are reasonable.

I'd mildly prefer changing the behavior of GDB - but only if we can
get an additional enhancement that I don't think we have yet: "*" at
the PC...

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2009-10-08 16:23 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02  0:50 Paul Pluzhnikov
2009-10-02  6:52 ` Joel Brobecker
2009-10-02 18:31   ` Paul Pluzhnikov
2009-10-02 18:49     ` Joel Brobecker
2009-10-02 15:17 ` Tom Tromey
2009-10-08 16:16 ` Paul Pluzhnikov
2009-10-08 16:23   ` Daniel Jacobowitz [this message]
2009-10-08 16:25     ` Joel Brobecker
2009-10-08 16:52     ` Paul Pluzhnikov
2009-10-08 17:29       ` Daniel Jacobowitz
2009-10-08 17:33         ` Joel Brobecker
2009-10-16 23:07       ` Paul Pluzhnikov
2009-10-16 23:11         ` Paul Pluzhnikov
2009-10-17  8:33           ` Eli Zaretskii
2009-10-17 15:50             ` Paul Pluzhnikov
2009-10-17 16:49               ` Eli Zaretskii
2009-10-17 17:08                 ` Paul Pluzhnikov
2009-10-17 19:55                   ` Eli Zaretskii
2009-10-19 17:47         ` Tom Tromey
2009-10-19 18:09           ` Paul Pluzhnikov
2009-10-19 18:20             ` Paul Pluzhnikov
2009-10-19 18:30             ` Tom Tromey
2009-10-21  0:22               ` Paul Pluzhnikov
2009-10-21  4:07                 ` Eli Zaretskii
2009-10-21 18:06                   ` Paul Pluzhnikov
2009-10-21 18:16                     ` Eli Zaretskii
2009-10-21 17:24                 ` Tom Tromey
2009-10-19 18:49             ` Daniel Jacobowitz
2009-10-19 19:40               ` Eli Zaretskii
2009-10-19 19:55                 ` Daniel Jacobowitz
2009-10-19 19:40               ` Joel Brobecker
2009-10-19 19:56                 ` Daniel Jacobowitz
2009-10-19 20:03                   ` Tom Tromey
2009-10-19 20:10                     ` Joel Brobecker
2009-10-19 20:23                       ` Paul Pluzhnikov
2009-10-19 20:47                         ` Daniel Jacobowitz
2009-10-20 16:04               ` Tom Tromey
2009-10-08 16:24   ` Joel Brobecker
2009-10-08 17:16     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091008162350.GA8625@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox