Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: don.lee@sunplusct.com
Cc: Pierre Muller <muller@ics.u-strasbg.fr>,
	donlee@sourceware.org, 	gdb-patches@sourceware.org
Subject: Re: [PING] About score-tdep commit
Date: Wed, 14 Oct 2009 02:05:00 -0000	[thread overview]
Message-ID: <20091014020443.GN5272@adacore.com> (raw)
In-Reply-To: <OF97F5AD8B.A88E78E5-ON4825764B.0031809B-4825764B.00335896@sunplusct.com>

> My fault, I didn't post my patch to gdb-patches, next time
> I'll do this.

I would prefer if you deleted the code completely, instead of commenting
it out.  We're still cleaning up dead code that was commented-out years
ago.  If someone needs the code back, it's very easy to get it back from
a previous version of that file.  Can you do that cleanup, please?

Note that we've occasionally commented out code like this, but there
should be a comment explaining why the code was commented out, and we
should have a plan to address the issue in the short to medium term.
Even then, I still think that commenting code out is usually wrong.

> >   This commit is only in main branch, shouldn't this also be
> >   included in gdb 7.0 branch as it removes code that is surely
> >   broken in the branch?
> 
> Yes, it should be. Should I write this change to 7.0 branch (looks
> like I can't write to this branch) or other one will do this?

If you don't mind, can you do the commit? However, please do not
commit the change as you made it on Sept 27th.  Instead, do the
cleanup I suggested above, and commit both patches on the branch,
or a merged version of both patches.

Thank you,
-- 
Joel


  reply	other threads:[~2009-10-14  2:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090806102838.12059.qmail@sourceware.org>
2009-09-03  7:56 ` [ARI regression] " Pierre Muller
2009-09-17  7:34 ` [PING] " Pierre Muller
2009-09-17 16:05   ` Joel Brobecker
2009-09-27  4:22     ` don.lee
2009-10-03 13:06       ` Pierre Muller
2009-10-10  9:21         ` don.lee
2009-10-14  2:05           ` Joel Brobecker [this message]
2009-10-19  9:51             ` don.lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091014020443.GN5272@adacore.com \
    --to=brobecker@adacore.com \
    --cc=don.lee@sunplusct.com \
    --cc=donlee@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox