From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25257 invoked by alias); 14 Oct 2009 02:05:00 -0000 Received: (qmail 25179 invoked by uid 22791); 14 Oct 2009 02:04:59 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Oct 2009 02:04:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8DC732BABC1; Tue, 13 Oct 2009 22:04:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NburVNJRMLQ4; Tue, 13 Oct 2009 22:04:53 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 16F442BAB18; Tue, 13 Oct 2009 22:04:52 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3A5EBF58A0; Tue, 13 Oct 2009 19:04:43 -0700 (PDT) Date: Wed, 14 Oct 2009 02:05:00 -0000 From: Joel Brobecker To: don.lee@sunplusct.com Cc: Pierre Muller , donlee@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PING] About score-tdep commit Message-ID: <20091014020443.GN5272@adacore.com> References: <000f01ca442a$4bc5f460$e351dd20$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00293.txt.bz2 > My fault, I didn't post my patch to gdb-patches, next time > I'll do this. I would prefer if you deleted the code completely, instead of commenting it out. We're still cleaning up dead code that was commented-out years ago. If someone needs the code back, it's very easy to get it back from a previous version of that file. Can you do that cleanup, please? Note that we've occasionally commented out code like this, but there should be a comment explaining why the code was commented out, and we should have a plan to address the issue in the short to medium term. Even then, I still think that commenting code out is usually wrong. > > This commit is only in main branch, shouldn't this also be > > included in gdb 7.0 branch as it removes code that is surely > > broken in the branch? > > Yes, it should be. Should I write this change to 7.0 branch (looks > like I can't write to this branch) or other one will do this? If you don't mind, can you do the commit? However, please do not commit the change as you made it on Sept 27th. Instead, do the cleanup I suggested above, and commit both patches on the branch, or a merged version of both patches. Thank you, -- Joel