[PING] About score-tdep commit

["Pierre Muller" <muller@ics.u-strasbg.fr>]

  Branch 7.0 is open now,
but no one reacted to this email I sent
where I said that the watchpoint
related code for score-tdep
is non functional.
  Can we leave this as is in 7.0?


Pierre Muller
ARI maintainer for GDB







First message:

  Hi Don,

  looking at 
http://sourceware.org/gdb/current/ari/
I found a revival of TARGET_HAS_HARDWARE_WATCHPOINTS 
macros, which should not be there.

  your commit of score-tdep.h was apparently approved in march
but you committed it only in august.
  In the mean time, the macro
TARGET_HAS_HARDWARE_WATCHPOINTS has been removed
and several other macros have been renamed
TARGET_CAN_USE_HARDWARE_WATCHPOINT => target_can_use_hardware_watchpoint
STOPPED_BY_WATCHPOINT => target_stopped_by_watchpoint
HAVE_CONTINUABLE_HARDWARE_WATCHPOINT => target_have_continuable_watchpoint
TARGET_REGION_OK_FOR_HW_WATCHPOINT => target_region_ok_for_hw_watchpoint

  Thus the current code is not functional.

  All the hardware watchpoint related macros
that you set in score-tdep.c should be replaced by
appropriate entry in a target_ops struct...

  But I saw no target_ops for your system,
thus I don't really know how to fix your code.
Could you try to look into this?

Pierre Muller
GDB ARI (Awk Regression Index) maintainer


> -----Message d'origine-----
> De : gdb-cvs-owner@sourceware.org [mailto:gdb-cvs-owner@sourceware.org]
> De la part de donlee@sourceware.org
> Envoyé : Thursday, August 06, 2009 12:29 PM
> À : gdb-cvs@sourceware.org
> Objet : src/gdb ChangeLog MAINTAINERS NEWS configure.t ...
> 
> CVSROOT:	/cvs/src
> Module name:	src
> Changes by:	donlee@sourceware.org	2009-08-06 10:28:38
> 
> Modified files:
> 	gdb            : ChangeLog MAINTAINERS NEWS configure.tgt
> 	                 score-tdep.c score-tdep.h
> 
> Log message:
> 	* score-tdep.c: Support a new Sunplus CT S+core variant, S+core
> 3.
> 	* score-tdep.h: Ditto.
> 	* NEWS: Ditto.
> 	* configure.tgt: Test do we have a simulator.
> 	* MAINTAINERS: Add myself under target score
> 
> Patches:
> http://sources.redhat.com/cgi-
> bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.10781&r2=1.10782
> http://sources.redhat.com/cgi-
> bin/cvsweb.cgi/src/gdb/MAINTAINERS.diff?cvsroot=src&r1=1.422&r2=1.423
> http://sources.redhat.com/cgi-
> bin/cvsweb.cgi/src/gdb/NEWS.diff?cvsroot=src&r1=1.324&r2=1.325
> http://sources.redhat.com/cgi-
> bin/cvsweb.cgi/src/gdb/configure.tgt.diff?cvsroot=src&r1=1.223&r2=1.224
> http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/score-
> tdep.c.diff?cvsroot=src&r1=1.20&r2=1.21
> http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/score-
> tdep.h.diff?cvsroot=src&r1=1.5&r2=1.6