From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Paul Pluzhnikov <ppluzhnikov@google.com>, dje@google.com
Subject: Re: [patch] Allow gdbserver to dynamically lookup libthread_db.so.1
Date: Tue, 13 Oct 2009 13:53:00 -0000 [thread overview]
Message-ID: <200910131453.23038.pedro@codesourcery.com> (raw)
In-Reply-To: <200910050403.28304.pedro@codesourcery.com>
On Monday 05 October 2009 04:03:27, Pedro Alves wrote:
> > and B) contradicts current usage (before the patch):
> >
> > grep current_process thread-db.c
> > ? struct process_info_private *proc = current_process()->private;
> > ? struct process_info_private *proc = current_process()->private;
> > ? struct process_info_private *proc = current_process()->private;
> > ? struct process_info *proc = current_process ();
>
> Probably a typo followed by copy-paste, and I'm probably to blame
> for those. ?It there are any after your patch goes in, I'll take
> care of fixing them.
'grep -rn "[a-zA-Z0-9_]()->" *' found only these left.
Applied.
--
Pedro Alves
2009-10-13 Pedro Alves <pedro@codesourcery.com>
gdb/
* infcall.c (call_function_by_hand): Formatting.
2009-10-13 Pedro Alves <pedro@codesourcery.com>
gdb/gdbserver/
* proc-service.c (ps_lgetregs): Formatting.
---
gdb/gdbserver/proc-service.c | 2 +-
gdb/infcall.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Index: src/gdb/gdbserver/proc-service.c
===================================================================
--- src.orig/gdb/gdbserver/proc-service.c 2009-10-12 12:37:03.000000000 +0100
+++ src/gdb/gdbserver/proc-service.c 2009-10-12 12:37:22.000000000 +0100
@@ -111,7 +111,7 @@ ps_lgetregs (gdb_ps_prochandle_t ph, lwp
current_inferior = reg_inferior;
the_target->fetch_registers (-1);
- gregset_info()->fill_function (gregset);
+ gregset_info ()->fill_function (gregset);
current_inferior = save_inferior;
return PS_OK;
Index: src/gdb/infcall.c
===================================================================
--- src.orig/gdb/infcall.c 2009-10-12 12:37:03.000000000 +0100
+++ src/gdb/infcall.c 2009-10-12 12:37:36.000000000 +0100
@@ -940,7 +940,7 @@ When the function is done executing, GDB
user. */
if (terminate_bp != NULL
- && (inferior_thread()->stop_bpstat->breakpoint_at->address
+ && (inferior_thread ()->stop_bpstat->breakpoint_at->address
== terminate_bp->loc->address))
{
/* We must get back to the frame we were before the
next prev parent reply other threads:[~2009-10-13 13:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 16:34 Paul Pluzhnikov
2009-09-02 16:43 ` Paul Pluzhnikov
2009-09-02 16:47 ` Pedro Alves
2009-09-02 17:16 ` Paul Pluzhnikov
2009-09-02 17:19 ` Doug Evans
2009-10-02 23:51 ` Paul Pluzhnikov
2009-10-04 20:32 ` Pedro Alves
2009-10-05 1:49 ` Paul Pluzhnikov
2009-10-05 3:03 ` Pedro Alves
2009-10-13 13:53 ` Pedro Alves [this message]
2009-10-06 23:08 ` Paul Pluzhnikov
2009-10-06 23:44 ` Pedro Alves
2009-10-07 0:27 ` Paul Pluzhnikov
2009-10-08 18:08 ` Pedro Alves
2009-10-08 19:05 ` Daniel Jacobowitz
2009-10-08 19:21 ` Paul Pluzhnikov
2009-10-08 19:42 ` Daniel Jacobowitz
2009-10-16 0:41 ` Paul Pluzhnikov
2009-10-22 21:03 ` Paul Pluzhnikov
2009-10-29 16:52 ` Paul Pluzhnikov
2009-10-29 17:27 ` Daniel Jacobowitz
2009-10-29 17:45 ` Paul Pluzhnikov
2009-10-08 19:36 ` Paul Pluzhnikov
2009-10-08 22:58 ` Pedro Alves
2009-10-04 20:34 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910131453.23038.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox