From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24032 invoked by alias); 13 Oct 2009 13:53:32 -0000 Received: (qmail 24022 invoked by uid 22791); 13 Oct 2009 13:53:31 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Oct 2009 13:53:23 +0000 Received: (qmail 15162 invoked from network); 13 Oct 2009 13:53:21 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Oct 2009 13:53:21 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] Allow gdbserver to dynamically lookup libthread_db.so.1 Date: Tue, 13 Oct 2009 13:53:00 -0000 User-Agent: KMail/1.9.10 Cc: Paul Pluzhnikov , dje@google.com References: <20090902163344.833F476568@localhost> <8ac60eac0910041849q5e95466br6190a355f8192eeb@mail.gmail.com> <200910050403.28304.pedro@codesourcery.com> In-Reply-To: <200910050403.28304.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910131453.23038.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00270.txt.bz2 On Monday 05 October 2009 04:03:27, Pedro Alves wrote: > > and B) contradicts current usage (before the patch): > > > > grep current_process thread-db.c > > ? struct process_info_private *proc = current_process()->private; > > ? struct process_info_private *proc = current_process()->private; > > ? struct process_info_private *proc = current_process()->private; > > ? struct process_info *proc = current_process (); > > Probably a typo followed by copy-paste, and I'm probably to blame > for those. ?It there are any after your patch goes in, I'll take > care of fixing them. 'grep -rn "[a-zA-Z0-9_]()->" *' found only these left. Applied. -- Pedro Alves 2009-10-13 Pedro Alves gdb/ * infcall.c (call_function_by_hand): Formatting. 2009-10-13 Pedro Alves gdb/gdbserver/ * proc-service.c (ps_lgetregs): Formatting. --- gdb/gdbserver/proc-service.c | 2 +- gdb/infcall.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: src/gdb/gdbserver/proc-service.c =================================================================== --- src.orig/gdb/gdbserver/proc-service.c 2009-10-12 12:37:03.000000000 +0100 +++ src/gdb/gdbserver/proc-service.c 2009-10-12 12:37:22.000000000 +0100 @@ -111,7 +111,7 @@ ps_lgetregs (gdb_ps_prochandle_t ph, lwp current_inferior = reg_inferior; the_target->fetch_registers (-1); - gregset_info()->fill_function (gregset); + gregset_info ()->fill_function (gregset); current_inferior = save_inferior; return PS_OK; Index: src/gdb/infcall.c =================================================================== --- src.orig/gdb/infcall.c 2009-10-12 12:37:03.000000000 +0100 +++ src/gdb/infcall.c 2009-10-12 12:37:36.000000000 +0100 @@ -940,7 +940,7 @@ When the function is done executing, GDB user. */ if (terminate_bp != NULL - && (inferior_thread()->stop_bpstat->breakpoint_at->address + && (inferior_thread ()->stop_bpstat->breakpoint_at->address == terminate_bp->loc->address)) { /* We must get back to the frame we were before the