From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/4] Fix hw watchpoints: reordered / simultaneously hit [fixup #1]
Date: Wed, 07 Oct 2009 18:39:00 -0000 [thread overview]
Message-ID: <20091007183858.GR5689@adacore.com> (raw)
In-Reply-To: <20091003172302.GD26203@host0.dyn.jankratochvil.net>
> Still I would like to get accepted first the watchpoints set and the
> cleanups can get in later, the watchpoints were first posted for FSF
> GDB on 14 Oct 2007.
We can definitely work on that, although it's very slow going because
I'm actually learning everything that you must have been learning when
you first started looking at the issues. However, my concern about
postponing this cleanup is that we might forget about it as soon as
this patch set is included. And even if we don't, we might forget about
this workaround that we're adding right now.
My suggestion, instead of wrapping that one call to
target_stopped_by_watchpoint was to turn that macro into a function which
does the wrapping for you, before it eventually calls the target_ops method.
I cannot find the linux_nat_stopped_data_address that you are refering to,
not even in the patches you sent so I don't know if it's affecting my
suggestion or not.
--
Joel
next prev parent reply other threads:[~2009-10-07 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 19:46 [patch 2/4] Fix hw watchpoints: reordered / simultaneously hit Jan Kratochvil
2009-10-02 22:13 ` [patch 2/4] Fix hw watchpoints: reordered / simultaneously hit [fixup #1] Jan Kratochvil
2009-10-02 23:01 ` Joel Brobecker
2009-10-03 17:23 ` Jan Kratochvil
2009-10-07 18:39 ` Joel Brobecker [this message]
2009-10-12 16:00 ` Jan Kratochvil
2009-10-12 18:58 ` Eli Zaretskii
2009-10-13 16:02 ` Jan Kratochvil
2009-11-03 1:12 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007183858.GR5689@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox