From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30648 invoked by alias); 7 Oct 2009 18:39:14 -0000 Received: (qmail 30638 invoked by uid 22791); 7 Oct 2009 18:39:14 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Oct 2009 18:39:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 741BA2BAC52; Wed, 7 Oct 2009 14:39:04 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3qrnJh4Hrmkj; Wed, 7 Oct 2009 14:39:04 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3C72D2BAC3D; Wed, 7 Oct 2009 14:39:04 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5472CF589F; Wed, 7 Oct 2009 11:38:58 -0700 (PDT) Date: Wed, 07 Oct 2009 18:39:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 2/4] Fix hw watchpoints: reordered / simultaneously hit [fixup #1] Message-ID: <20091007183858.GR5689@adacore.com> References: <20090817194612.GC10694@host0.dyn.jankratochvil.net> <20091002221254.GA7767@host0.dyn.jankratochvil.net> <20091002230124.GG10338@adacore.com> <20091003172302.GD26203@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091003172302.GD26203@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00155.txt.bz2 > Still I would like to get accepted first the watchpoints set and the > cleanups can get in later, the watchpoints were first posted for FSF > GDB on 14 Oct 2007. We can definitely work on that, although it's very slow going because I'm actually learning everything that you must have been learning when you first started looking at the issues. However, my concern about postponing this cleanup is that we might forget about it as soon as this patch set is included. And even if we don't, we might forget about this workaround that we're adding right now. My suggestion, instead of wrapping that one call to target_stopped_by_watchpoint was to turn that macro into a function which does the wrapping for you, before it eventually calls the target_ops method. I cannot find the linux_nat_stopped_data_address that you are refering to, not even in the patches you sent so I don't know if it's affecting my suggestion or not. -- Joel