Re: [patch 2/4] Fix hw watchpoints: reordered / simultaneously hit [fixup #1]

[Joel Brobecker <brobecker@adacore.com>]

Jan,

Sorry for the delay on reviewing this...

I'll confess that I am having a hard time following the patch, now,
since we're now trying to achieve three different things: there is
the fact that we want one of the target operations to take a ptid,
and then the fact that we use that opportunity to change the interface,
and (oh yeah!) a bug that we're trying to fix on x86/x86_64. Baby
steps are really easier to follow, at least for me.

> If we should do the upgrade my primary reason for this change is that
> I find the single functionality being split into two target functions
> (to_stopped_by_watchpoint and to_stopped_data_address) to be
> confusing.  Chose a new name to easily be able to keep the old
> deprecated implementations working until its host maintainers can get
> to update them as I cannot even compile some of the host files.

I'm having second thoughts on this one, and I am no longer seeing
much benefit in one interface vs the other (personal opinion, of course).
In fact, the function semantics are not very confusing when you look
at how the functions are used by the callers.  It might be confusing
for the implementation, although that would be very easy to fix by
improved documentation in the target.h code.

That being said, I'm still 50/50 on this.  If other maintainers would
like to merge the two functions, then I would be fine with that.

But I see that such a transition would leave the code in a transitional
state where we have both the old code and the new code co-existing.
The problem is that it does not help maintaining the code while
transitioning, and I fear that transitions of this kind can take
a long time before we complete them.  I do not normally hesitate
making this sort of progressive change when I can see a clear benefit,
but I just don't see a clear-cut benefit right now. Anything I might
have missed?

(I left patch #1 out for now, as it is now dependent on this patch)

-- 
Joel