From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Pierre Muller" <muller@ics.u-strasbg.fr>
Subject: Re: [RFA] testsuite: Avoid auto-import warning on cygwin/mingw
Date: Fri, 02 Oct 2009 00:24:00 -0000 [thread overview]
Message-ID: <200910020123.53952.pedro@codesourcery.com> (raw)
In-Reply-To: <000f01ca42e3$e13cad60$a3b60820$@u-strasbg.fr>
On Thursday 01 October 2009 23:09:42, Pierre Muller wrote:
> Adding --enable-auto-import to link stage
> fixes this problem.
>
> Is this OK?
>
I _think_ the idea is fine. IWBN to have basic tests covering
printing auto-imported vs dllimported variables,
and covering stepping into import-lib'ed dll functions (through
the __imp_ trampolines).
> --- lib/gdb.exp 13 Jul 2009 19:24:18 -0000 1.119
> +++ lib/gdb.exp 1 Oct 2009 22:03:25 -0000
> @@ -1731,7 +1731,10 @@ proc gdb_compile {source dest type optio
> lappend options "additional_flags=-L${outdir}"
> } elseif { [istarget "mips-sgi-irix*"] } {
> lappend options "additional_flags=-rpath ${outdir}"
> - }
> + } elseif { ([istarget "*-*-mingw*"]
> + || [istarget *-*-cygwin*]) } {
> + lappend new_options
> "additional_flags=-Wl,--enable-auto-import"
Did you mean 'lappend options'?
> + }
> }
> } elseif { $opt == "shlib_load" } {
> if { ([istarget "*-*-mingw*"]
>
>
--
Pedro Alves
next prev parent reply other threads:[~2009-10-02 0:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 22:09 Pierre Muller
2009-10-02 0:24 ` Pedro Alves [this message]
2009-10-02 7:29 ` [RFA-v2] " Pierre Muller
2009-10-02 18:09 ` Pedro Alves
2009-10-02 20:57 ` Tom Tromey
2009-10-02 21:35 ` Pierre Muller
2009-10-02 22:19 ` Pedro Alves
2009-10-02 22:27 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910020123.53952.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox