From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67420-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18416 invoked by alias); 2 Oct 2009 00:24:01 -0000
Received: (qmail 18381 invoked by uid 22791); 2 Oct 2009 00:24:01 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Oct 2009 00:23:56 +0000
Received: (qmail 4392 invoked from network); 2 Oct 2009 00:23:54 -0000
Received: from unknown (HELO orlando) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 2 Oct 2009 00:23:54 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] testsuite: Avoid auto-import warning on cygwin/mingw
Date: Fri, 02 Oct 2009 00:24:00 -0000
User-Agent: KMail/1.9.10
Cc: "Pierre Muller" <muller@ics.u-strasbg.fr>
References: <000f01ca42e3$e13cad60$a3b60820$@u-strasbg.fr>
In-Reply-To: <000f01ca42e3$e13cad60$a3b60820$@u-strasbg.fr>
MIME-Version: 1.0
Content-Type: text/plain;   charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200910020123.53952.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00043.txt.bz2

On Thursday 01 October 2009 23:09:42, Pierre Muller wrote:

> Adding --enable-auto-import to link stage
> fixes this problem.
> 
> Is this OK?
> 

I _think_ the idea is fine.  IWBN to have basic tests covering
printing auto-imported vs dllimported variables,
and covering stepping into import-lib'ed dll functions (through
the __imp_ trampolines).

> --- lib/gdb.exp	13 Jul 2009 19:24:18 -0000	1.119
> +++ lib/gdb.exp	1 Oct 2009 22:03:25 -0000
> @@ -1731,7 +1731,10 @@ proc gdb_compile {source dest type optio
>                      lappend options "additional_flags=-L${outdir}"
>                  } elseif { [istarget "mips-sgi-irix*"] } {
>                      lappend options "additional_flags=-rpath ${outdir}"
> -                }
> +                } elseif { ([istarget "*-*-mingw*"]
> +			    || [istarget *-*-cygwin*]) } {
> +		    lappend new_options
> "additional_flags=-Wl,--enable-auto-import"

Did you mean 'lappend options'?

> +		} 
>              }
>  	} elseif { $opt == "shlib_load" } {
>  	    if { ([istarget "*-*-mingw*"]
> 
> 

-- 
Pedro Alves