From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <tromey@redhat.com>, "'Pedro Alves'" <pedro@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA-v2] testsuite: Avoid auto-import warning on cygwin/mingw
Date: Fri, 02 Oct 2009 21:35:00 -0000 [thread overview]
Message-ID: <000601ca43a8$49a83e90$dcf8bbb0$@u-strasbg.fr> (raw)
In-Reply-To: <m3my49o6oz.fsf@fleche.redhat.com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : Friday, October 02, 2009 10:57 PM
> À : Pedro Alves
> Cc : Pierre Muller; gdb-patches@sourceware.org
> Objet : Re: [RFA-v2] testsuite: Avoid auto-import warning on
> cygwin/mingw
>
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> >> 'foreach opt $options {'
>
> Pedro> Hmmm, I would have thought that foreach would still
> Pedro> only iterate over the original elements of $options (since
> foreach
> Pedro> takes the values of $options, not the variable reference),
> Pedro> no matter if you lappend to options; or am I confused, and
> Pedro> does it really keep iterating over newly append items?
>
> You are not confused -- you are correct about this.
> "$options" is substituted when the statement is parsed, not on each
> loop
> iteration.
This confirms that the current additions to options
are finally discarded by the
set options $new_options
a few lines down,
and that my patch is correct, no?
May I commit this?
Pierre
next prev parent reply other threads:[~2009-10-02 21:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 22:09 [RFA] " Pierre Muller
2009-10-02 0:24 ` Pedro Alves
2009-10-02 7:29 ` [RFA-v2] " Pierre Muller
2009-10-02 18:09 ` Pedro Alves
2009-10-02 20:57 ` Tom Tromey
2009-10-02 21:35 ` Pierre Muller [this message]
2009-10-02 22:19 ` Pedro Alves
2009-10-02 22:27 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000601ca43a8$49a83e90$dcf8bbb0$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox