Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] Add cleanup branch for std::terminate breakpoints in 	call_function_by_hand
Date: Thu, 01 Oct 2009 16:44:00 -0000	[thread overview]
Message-ID: <20091001164439.GM10338@adacore.com> (raw)
In-Reply-To: <4AC4D353.3010605@redhat.com>

> 2009-10-01  Phil Muldoon <pmuldoon@redhat.com>
>
>     * infcall.c (call_function_by_hand): Add a new cleanup branch for
>     std::terminate breakpoint.

This is OK for the HEAD, except for one minor tiny comment:

> +  struct cleanup *terminate_bp_cleanup;

Can you initialize this to NULL? I know from code inspection that
you cannot use it uninitialized, but you never know. Plus some compilers
may not be smart enough to detect that...

Thanks,
-- 
Joel


  reply	other threads:[~2009-10-01 16:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01 16:05 Phil Muldoon
2009-10-01 16:44 ` Joel Brobecker [this message]
2009-10-01 20:12   ` committed: " Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091001164439.GM10338@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox