From: Phil Muldoon <pmuldoon@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: committed: Re: [patch] Add cleanup branch for std::terminate breakpoints in call_function_by_hand
Date: Thu, 01 Oct 2009 20:12:00 -0000 [thread overview]
Message-ID: <4AC50D16.3000408@redhat.com> (raw)
In-Reply-To: <20091001164439.GM10338@adacore.com>
On 10/01/2009 05:44 PM, Joel Brobecker wrote:
Hi Joel,
>> 2009-10-01 Phil Muldoon<pmuldoon@redhat.com>
>>
>> * infcall.c (call_function_by_hand): Add a new cleanup branch for
>> std::terminate breakpoint.
>>
> This is OK for the HEAD, except for one minor tiny comment:
>
>
>> + struct cleanup *terminate_bp_cleanup;
>>
> Can you initialize this to NULL?
>
Done, and committed. Thanks for the prompt review!
Regards
Phil
prev parent reply other threads:[~2009-10-01 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 16:05 Phil Muldoon
2009-10-01 16:44 ` Joel Brobecker
2009-10-01 20:12 ` Phil Muldoon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC50D16.3000408@redhat.com \
--to=pmuldoon@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox