From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8721 invoked by alias); 1 Oct 2009 16:44:51 -0000 Received: (qmail 8712 invoked by uid 22791); 1 Oct 2009 16:44:50 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Oct 2009 16:44:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3F3042BAB4E; Thu, 1 Oct 2009 12:44:42 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qBn11sSlApLo; Thu, 1 Oct 2009 12:44:42 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0B1182BAB31; Thu, 1 Oct 2009 12:44:42 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 576ADF593D; Thu, 1 Oct 2009 09:44:39 -0700 (PDT) Date: Thu, 01 Oct 2009 16:44:00 -0000 From: Joel Brobecker To: Phil Muldoon Cc: gdb-patches ml Subject: Re: [patch] Add cleanup branch for std::terminate breakpoints in call_function_by_hand Message-ID: <20091001164439.GM10338@adacore.com> References: <4AC4D353.3010605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AC4D353.3010605@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00015.txt.bz2 > 2009-10-01 Phil Muldoon > > * infcall.c (call_function_by_hand): Add a new cleanup branch for > std::terminate breakpoint. This is OK for the HEAD, except for one minor tiny comment: > + struct cleanup *terminate_bp_cleanup; Can you initialize this to NULL? I know from code inspection that you cannot use it uninitialized, but you never know. Plus some compilers may not be smart enough to detect that... Thanks, -- Joel